feat(coderd): include shared workspaces in workspace updates#25403
Open
aslilac wants to merge 1 commit into
Open
feat(coderd): include shared workspaces in workspace updates#25403aslilac wants to merge 1 commit into
aslilac wants to merge 1 commit into
Conversation
Widen the WorkspaceUpdate stream so it covers workspaces shared with the user via user_acl / group_acl, not just workspaces they own. This unblocks shared-workspace support in Coder Desktop without any proto changes. - Drop the hard owner_id filter from GetWorkspacesAndAgentsByOwnerID; the existing @authorize_filter (ActionRead on rbac.ResourceWorkspace) already covers both owned and ACL-shared workspaces. - Also subscribe to wspubsub.AllWorkspaceEventChannel so build events on shared workspaces wake up the subscriber's diff/requery flow. Generated with Coder Agents on behalf of @aslilac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the workspace-updates stream so it covers workspaces shared with the user via
user_acl/group_acl, not only ones they own. Unblocks shared-workspaces support in Coder Desktop with no proto changes.GetWorkspacesAndAgentsByOwnerIDdrops the hardowner_idfilter; the existing@authorize_filter(ActionRead onrbac.ResourceWorkspace) already covers owned + ACL-shared workspaces.subnow also subscribes towspubsub.AllWorkspaceEventChannelso build events on shared workspaces wake up its diff/requery flow.Notes for reviewers
ownerIDis removed end-to-end fromGetWorkspacesAndAgentsByOwnerID/GetAuthorizedWorkspacesAndAgentsByOwnerID. The name is kept to avoid further churn; a rename can land separately.WorkspaceBuildUpdatepayloads (notWorkspaceEvent), so the new subscription usesHandleWorkspaceBuildUpdateand just triggers a re-query. Agent-only events for shared workspaces will not wake the subscriber, butproduceUpdatewill still pick up any state diff on the next build or owner-side event.