fix: bump goldmark to v1.7.17 to fix XSS (CVE-2026-5160)#25216
Merged
Conversation
goldmark v1.7.16 is vulnerable to XSS due to improper ordering of URL validation and normalization. The renderer validates link destinations using a prefix-based check before resolving HTML entities, allowing bypass with entity-encoded javascript: URIs. Bump to v1.7.17 which fixes the vulnerability.
f0ssel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
github.com/yuin/goldmarkfrom v1.7.16 to v1.7.17 to fix CVE-2026-5160.goldmark v1.7.16 is vulnerable to XSS due to improper ordering of URL validation and normalization. The renderer validates link destinations using a prefix-based check (
IsDangerousURL) before resolving HTML entities, allowing an attacker to bypass validation with entity-encodedjavascript:URIs.This is the minimal fix for the IronBank finding on the
coder/coder-enterprise/coder-service-2:2.31.11image. The fix is already onmain(v1.8.2 via Hugo bump in #23957); this targets the v2.31.x release branch with only the goldmark dependency change.Closes ENT-8