Skip to content

refactor: use terraform provider methods for user secret env var names #24946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zedkipp merged 1 commit into from
May 5, 2026
Merged

refactor: use terraform provider methods for user secret env var names #24946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions provisioner/terraform/provision.go
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@zedkipp zedkipp May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing tests that ensure the env formatting is still correct:

coder/provisioner/terraform/provision_internal_test.go

Line 14 in 6341201

func TestProvisionEnv_UserSecrets(t *testing.T) {

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package terraform

import (
"context"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
Expand Down Expand Up @@ -419,14 +418,14 @@ func provisionEnv(

for _, secret := range userSecrets {
if secret.EnvName != "" {
env = append(env, fmt.Sprintf("CODER_SECRET_ENV_%s=%s", secret.EnvName, string(secret.Value)))
env = append(env, provider.SecretEnvEnvironmentVariable(secret.EnvName)+"="+string(secret.Value))
}
if secret.FilePath != "" {
// Environment variables are used to communicate the file path a
// secret should be written to. The hex encoding is done because
// file paths contain slashes, tildes, and dots that are illegal
// in environment variable names.
env = append(env, fmt.Sprintf("CODER_SECRET_FILE_%s=%s", hex.EncodeToString([]byte(secret.FilePath)), string(secret.Value)))
env = append(env, provider.SecretFileEnvironmentVariable(secret.FilePath)+"="+string(secret.Value))
}
}

Expand Down
Loading