fix(coderd): fix TestListChats/PinnedOnFirstPage race timeout#24641
Merged
Conversation
Insert filler chats directly into the database with completed status instead of creating them through the API. This avoids spawning 52 background chatd processors that each time out on title generation, causing the test to exceed the 25s WaitLong timeout under -race.
ibetitsmike
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completedstatus instead of creating them via the APItestutil.Eventuallypolling loop that waited for all 52 chats to reach terminal status-race, exceeding the 25sWaitLongtimeoutFlake: https://github.com/coder/coder/actions/runs/24789695935/job/72543519963?pr=24438