fix(aibridge): track Charm Crush client and session ID#24630
Merged
Conversation
The actual Crush user-agent is Charm-Crush/{version} (hyphenated),
but GuessClient only checked for the space-separated charm crush/ prefix.
Now matches both formats for backwards compatibility.
Adds an explicit ClientCrush case to GuessSessionID. Crush does not
currently send a session ID header, so this returns nil (consistent
with ClientZed, ClientRoo, and ClientCursor).
Ported from coder/aibridge#277
pawbana
approved these changes
Apr 22, 2026
Member
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: implemented by a Coder Agent using Claude Opus 4.6
Porting coder/aibridge#277 to coder/coder after the aibridge code move.
Summary
Fixes client detection and session ID tracking for the Charm Crush AI coding client.
Changes
Bug fix: User-Agent matching
The actual Crush user-agent is
Charm-Crush/{version} (https://charm.land/crush)(hyphenated), butGuessClientonly checked forcharm crush/(space-separated). After lowercasing,Charm-Crush/0.2.0becomescharm-crush/0.2.0, which did not match thecharm crush/prefix.Now matches both formats for backwards compatibility.
Session ID tracking
Adds an explicit
ClientCrushcase toGuessSessionID. Crush does not currently send a session ID header to upstream AI providers, so this returnsnil(consistent with howClientZed,ClientRoo, andClientCursorare handled).Tests
charm_crush_hyphentest case forGuessClientusing the real user-agent format.crush_returns_emptytest case forGuessSessionID.