chore(examples): update incus template#24616
Conversation
johnstcn
commented
Apr 22, 2026
- Decoupled provisioner from Incus host by passing agent token/URL via Incus Guest API
- Added a config watcher service to detect token updates and restart the agent automatically.
- Updates for compatibility with Incus provider 1.x
- Decoupled provisioner from Incus host by passing agent token/URL via Incus Guest API - Added a config watcher service to detect token updates and restart the agent automatically. - Updates for compatibility with Incus provider 1.x
|
/coder-agents-review |
There was a problem hiding this comment.
First-pass review (Netero only). The full review panel has not yet reviewed this PR; these are mechanical findings that should be addressed before the panel spends parallel review time.
The template rewrite is well-structured: decoupling the provisioner from the Incus host via the guest API is a clean architectural improvement, and the watcher service for stale tokens is a pragmatic solution to the provider ordering issue.
2 P0 findings, both lint blockers.
"Three em-dashes on new lines and two en-dashes for numeric ranges. Replace with periods, commas, or hyphens per project convention."
🤖 This review was automatically generated with Coder Agents.
matifali
left a comment
There was a problem hiding this comment.
A few nits but looks good to me
| option { | ||
| name = "Ubuntu 22.04 (Jammy)" | ||
| value = "images:ubuntu/22.04/cloud" | ||
| } |
There was a problem hiding this comment.
maybe replace with 26.04
Its new LTS
There was a problem hiding this comment.
It's not in the images: remote (yet)
| # needing the docker group (which would require a new login session). | ||
| if [ -S /var/run/docker.sock ]; then | ||
| sudo chown $(whoami) /var/run/docker.sock | ||
| fi |
There was a problem hiding this comment.
this is fine but when the user actually connects the group membership would have applied.
There was a problem hiding this comment.
not really, you have to do newgrp docker
- Replace em-dashes and en-dashes to fix lint/emdash - Add storage pool as a coder_parameter