Skip to content

fix(coderd/x/chatd/chatdebug): allow Anthropic per-modality ratelimit headers #24592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 2 commits into from
Apr 22, 2026
Merged

fix(coderd/x/chatd/chatdebug): allow Anthropic per-modality ratelimit headers #24592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024e129
fix(coderd/x/chatd/chatdebug): allow Anthropic per-modality ratelimit…
ThomasK33 Apr 21, 2026
640c868
fix(coderd/x/chatd/chatdebug): allowlist Priority Tier + fast-mode to…
ThomasK33 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 37 additions & 12 deletions coderd/x/chatd/chatdebug/redaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,44 @@ func consumeJSONEOF(decoder *json.Decoder) error {
return err
}

// safeRateLimitHeaderNames lists rate-limit headers that contain
// "token" in the name but carry numeric usage counters, not
// credentials. They are checked in isSensitiveName before the
// generic "token" substring match so they pass through unredacted.
// Add new entries here when a provider introduces a rate-limit
// header family containing "token" (e.g. Anthropic's per-modality,
// Priority Tier, or fast-mode headers).
var safeRateLimitHeaderNames = map[string]struct{}{
Comment thread
ThomasK33 marked this conversation as resolved.
"anthropic-ratelimit-requests-limit": {},
"anthropic-ratelimit-requests-remaining": {},
"anthropic-ratelimit-requests-reset": {},
"anthropic-ratelimit-tokens-limit": {},
"anthropic-ratelimit-tokens-remaining": {},
"anthropic-ratelimit-tokens-reset": {},
"x-ratelimit-limit-requests": {},
"x-ratelimit-limit-tokens": {},
"x-ratelimit-remaining-requests": {},
"x-ratelimit-remaining-tokens": {},
"x-ratelimit-reset-requests": {},
"x-ratelimit-reset-tokens": {},
"anthropic-ratelimit-requests-limit": {},
"anthropic-ratelimit-requests-remaining": {},
"anthropic-ratelimit-requests-reset": {},
"anthropic-ratelimit-tokens-limit": {},
"anthropic-ratelimit-tokens-remaining": {},
"anthropic-ratelimit-tokens-reset": {},
"anthropic-ratelimit-input-tokens-limit": {},
Comment thread
ThomasK33 marked this conversation as resolved.
"anthropic-ratelimit-input-tokens-remaining": {},
"anthropic-ratelimit-input-tokens-reset": {},
"anthropic-ratelimit-output-tokens-limit": {},
"anthropic-ratelimit-output-tokens-remaining": {},
"anthropic-ratelimit-output-tokens-reset": {},
Comment thread
ThomasK33 marked this conversation as resolved.
"anthropic-priority-input-tokens-limit": {},
"anthropic-priority-input-tokens-remaining": {},
"anthropic-priority-input-tokens-reset": {},
"anthropic-priority-output-tokens-limit": {},
"anthropic-priority-output-tokens-remaining": {},
"anthropic-priority-output-tokens-reset": {},
"anthropic-fast-input-tokens-limit": {},
"anthropic-fast-input-tokens-remaining": {},
"anthropic-fast-input-tokens-reset": {},
"anthropic-fast-output-tokens-limit": {},
"anthropic-fast-output-tokens-remaining": {},
"anthropic-fast-output-tokens-reset": {},
"x-ratelimit-limit-requests": {},
"x-ratelimit-limit-tokens": {},
"x-ratelimit-remaining-requests": {},
"x-ratelimit-remaining-tokens": {},
"x-ratelimit-reset-requests": {},
"x-ratelimit-reset-tokens": {},
}

// isSensitiveName reports whether a name (header or query parameter)
Expand Down
48 changes: 42 additions & 6 deletions coderd/x/chatd/chatdebug/redaction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,54 @@ func TestRedactHeaders(t *testing.T) {
t.Parallel()

headers := http.Header{
"Anthropic-Ratelimit-Tokens-Limit": {"1000000"},
"Anthropic-Ratelimit-Tokens-Remaining": {"999000"},
"Anthropic-Ratelimit-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"X-RateLimit-Limit-Tokens": {"120000"},
"X-RateLimit-Remaining-Tokens": {"119500"},
"X-RateLimit-Reset-Tokens": {"12ms"},
"Anthropic-Ratelimit-Tokens-Limit": {"1000000"},
"Anthropic-Ratelimit-Tokens-Remaining": {"999000"},
"Anthropic-Ratelimit-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Ratelimit-Input-Tokens-Limit": {"200000"},
"Anthropic-Ratelimit-Input-Tokens-Remaining": {"199000"},
"Anthropic-Ratelimit-Input-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Ratelimit-Output-Tokens-Limit": {"80000"},
"Anthropic-Ratelimit-Output-Tokens-Remaining": {"79500"},
"Anthropic-Ratelimit-Output-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Priority-Input-Tokens-Limit": {"10000"},
"Anthropic-Priority-Input-Tokens-Remaining": {"9618"},
"Anthropic-Priority-Input-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Priority-Output-Tokens-Limit": {"10000"},
"Anthropic-Priority-Output-Tokens-Remaining": {"6000"},
"Anthropic-Priority-Output-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Fast-Input-Tokens-Limit": {"50000"},
"Anthropic-Fast-Input-Tokens-Remaining": {"49000"},
"Anthropic-Fast-Input-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"Anthropic-Fast-Output-Tokens-Limit": {"25000"},
"Anthropic-Fast-Output-Tokens-Remaining": {"24000"},
"Anthropic-Fast-Output-Tokens-Reset": {"2026-03-31T08:55:26Z"},
"X-RateLimit-Limit-Tokens": {"120000"},
"X-RateLimit-Remaining-Tokens": {"119500"},
"X-RateLimit-Reset-Tokens": {"12ms"},
}

redacted := chatdebug.RedactHeaders(headers)
require.Equal(t, "1000000", redacted["Anthropic-Ratelimit-Tokens-Limit"])
require.Equal(t, "999000", redacted["Anthropic-Ratelimit-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Ratelimit-Tokens-Reset"])
require.Equal(t, "200000", redacted["Anthropic-Ratelimit-Input-Tokens-Limit"])
require.Equal(t, "199000", redacted["Anthropic-Ratelimit-Input-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Ratelimit-Input-Tokens-Reset"])
require.Equal(t, "80000", redacted["Anthropic-Ratelimit-Output-Tokens-Limit"])
require.Equal(t, "79500", redacted["Anthropic-Ratelimit-Output-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Ratelimit-Output-Tokens-Reset"])
require.Equal(t, "10000", redacted["Anthropic-Priority-Input-Tokens-Limit"])
require.Equal(t, "9618", redacted["Anthropic-Priority-Input-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Priority-Input-Tokens-Reset"])
require.Equal(t, "10000", redacted["Anthropic-Priority-Output-Tokens-Limit"])
require.Equal(t, "6000", redacted["Anthropic-Priority-Output-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Priority-Output-Tokens-Reset"])
require.Equal(t, "50000", redacted["Anthropic-Fast-Input-Tokens-Limit"])
require.Equal(t, "49000", redacted["Anthropic-Fast-Input-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Fast-Input-Tokens-Reset"])
require.Equal(t, "25000", redacted["Anthropic-Fast-Output-Tokens-Limit"])
require.Equal(t, "24000", redacted["Anthropic-Fast-Output-Tokens-Remaining"])
require.Equal(t, "2026-03-31T08:55:26Z", redacted["Anthropic-Fast-Output-Tokens-Reset"])
require.Equal(t, "120000", redacted["X-RateLimit-Limit-Tokens"])
require.Equal(t, "119500", redacted["X-RateLimit-Remaining-Tokens"])
require.Equal(t, "12ms", redacted["X-RateLimit-Reset-Tokens"])
Expand Down
Loading