fix(site/src/pages/WorkspacePage/WorkspaceNotifications): make workspace notification pills keyboard accessible#24536
Merged
Conversation
53451d6 to
b13d8f3
Compare
…cation pills keyboard accessible
b13d8f3 to
6c2bc20
Compare
jeremyruppel
approved these changes
Apr 22, 2026
Contributor
jeremyruppel
left a comment
There was a problem hiding this comment.
this works great, thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The workspace notification pills were implemented using Tooltip, which is hover-only and not reachable via keyboard navigation.
Replace Tooltip/TooltipProvider/TooltipTrigger with Popover/PopoverContent/PopoverTrigger, and change the trigger element from a non-interactive div to a button. This makes the notification pills fully keyboard accessible.
Screenshot:
Issue
Fix
