test: pin DateRangePicker calendar today to caller-supplied clock#24517
Merged
Conversation
The DateRangePicker accepts a `now` prop that stories and tests use to pin preset ranges and future-date disabling to a deterministic clock, but it never forwarded that value to the underlying Calendar. react-day-picker then computed its own `today` from wall-clock time, which drives both the "today" highlight modifier and the initial visible month, causing stories like `TemplateInsightsControls:Day` to flake as real time advanced.
jakehwll
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DateRangePickeraccepts anowprop that stories and tests use to pin preset ranges and future-date disabling to a deterministic clock, but it never forwarded that value to the underlyingCalendar.react-day-pickerthen computed its owntodayfrom wall-clock time, which drives both the "today" highlight modifier and the initial visible month — causing stories likeTemplateInsightsControls:Dayto flake as real time advanced.Thread
currentTimeintoreact-day-picker'stodayprop. Whennowis omitted (production usage),currentTimefalls back tonew Date(), which matchesreact-day-picker's existing default, so there is no runtime behavior change.