chore(site): replace CircularProgress with Spinner component - #24276
Merged
Conversation
<CircularProgress /><CircularProgress /> mui dependency
jakehwll
force-pushed
the
jakehwll/demui-circular-progress
branch
2 times, most recently
from
April 23, 2026 05:26
be160e0 to
abaf49b
Compare
<CircularProgress /> mui dependency…ent combobox deselection - Pill: fix lg variant adding text-sm (original never changed font size), move shared styles to base, use self-contained compound variants to avoid class override conflicts. - GitDeviceAuth: use Loader for the full-page loading state. - ChangeWorkspaceVersionDialog: ignore deselection in onValueChange to match the old Autocomplete disableClearable behavior.
jakehwll
force-pushed
the
jakehwll/demui-circular-progress
branch
6 times, most recently
from
April 23, 2026 07:40
74d851c to
28a7725
Compare
jakehwll
marked this pull request as ready for review
April 23, 2026 12:16
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d1b5ed3ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Callers were passing Emotion css props to Pill which no longer has Emotion support. Convert them to use the Pill type prop and Tailwind className instead. - UserRoleCell: map role styles to type=notice/active/inactive - PermissionPillsList: replace pillDefault styles with className=w-fit - IdpPillList: map error/default styles to type=error + className=w-fit - TemplateExampleCard: map active tag to type=active + hover classes
jakehwll
force-pushed
the
jakehwll/demui-circular-progress
branch
from
April 23, 2026 12:27
2d1b5ed to
e5c3d86
Compare
| The template has to be a .tar or .zip file. You can also use our{" "} | ||
| <Link href="/starter-templates">starter templates</Link> to getting | ||
| started with Coder. | ||
| <Link href="/starter-templates" showExternalIcon={false}> |
Contributor
There was a problem hiding this comment.
not for this PR, but this should presumably point to the new template builder: /templates/new/builder
jeremyruppel
approved these changes
Jul 14, 2026
jeremyruppel
left a comment
Contributor
There was a problem hiding this comment.
approving ahead of CI fixes 👍 nice one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces every
@mui/material/CircularProgressusage with the existingSpinnercomponent and removes the MUI dependency.border-border-successfor success outline,bg-surface-secondaryfor info background, etc.).CircularProgressforSpinner. SVG inherits 14px sizing from the Pill's[&_svg]:size-[14px]rule.CircularProgressand Emotion styles withSpinnerand Tailwind classes.CircularProgressand MUI Link withSpinner,Loader, and internalLink. Full-page loading state uses<Loader />instead of a bare spinner.Autocomplete/TextField/CircularProgresswithCombobox. Ignores deselection inonValueChangeto preserve the olddisableClearablebehavior.CircularProgresswithSpinner.CircularProgress,Stack, and Emotion styles withSpinnerand Tailwind classes.@mui/material/CircularProgressfromoptimizeDeps.SpinnerPropstype.