feat(agent/proto): add user secrets to agent manifest#24252
Merged
Conversation
Extend the agent protocol to include user secrets in the manifest. This allows the control plane to pass decrypted secret values to agents for runtime injection into workspaces as environment variables and files.
zedkipp
marked this pull request as ready for review
April 10, 2026 18:41
spikecurtis
approved these changes
Apr 10, 2026
| // written to a file. | ||
| string file_path = 2; | ||
| // The decrypted secret value. | ||
| bytes value = 3; |
Contributor
There was a problem hiding this comment.
a word of warning: you can't just set environment variables to arbitrary binary data. This needs to be validated before setting (as well as on insert of the secret).
Contributor
Author
There was a problem hiding this comment.
ack, we'll also do validation on file path values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workspace secrets as a field in the agent manifest protobuf schema. This allows the control plane to pass user secrets to agents for runtime injection into workspace sessions.
Message fields:
Related to user secrets RFC: https://www.notion.so/coderhq/User-Secrets-32cd579be59280a98192dec7b3b5daf1?source=copy_link#32dd579be59280ae80dad718afdb961a