Skip to content

chore: remove kyleosophy easter egg#24174

Merged
f0ssel merged 3 commits intorelease/2.32from
cj/r233/rm-kyleosophy
Apr 9, 2026
Merged

chore: remove kyleosophy easter egg#24174
f0ssel merged 3 commits intorelease/2.32from
cj/r233/rm-kyleosophy

Conversation

@johnstcn
Copy link
Copy Markdown
Member

@johnstcn johnstcn commented Apr 8, 2026

Remove the Kyleosophy alternative completion chimes easter egg (added in #23891).

(cherry picked from commit d03a7c8)

Remove the Kyleosophy alternative completion chimes feature
(added in PR #23891). The original completion chime, ChimeButton,
and cross-tab dedup logic are preserved.

- Delete chime_1.mp3 through chime_8.mp3 static assets
- Remove getKylesophyEnabled, setKylesophyEnabled, isKylesophyForced,
  KYLEOSOPHY_SOUNDS, lastSoundUrl from chime.ts
- Revert playChimeAudio/playChime to original single-sound signatures
- Remove kyleosophy tests and stories
- Remove Kyleosophy settings toggle from AgentSettingsBehaviorPageView

(cherry picked from commit d03a7c8)
@johnstcn johnstcn self-assigned this Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 20:23
@johnstcn johnstcn changed the base branch from main to release/2.33.0-rc April 8, 2026 20:25
@johnstcn johnstcn requested a review from f0ssel April 8, 2026 20:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the “Kyleosophy” alternative completion-chime easter egg from the Agents UI by deleting the extra audio assets, removing the preference/toggle wiring, and reverting the chime helper back to always using the default /chime.mp3.

Changes:

  • Remove Kyleosophy preference helpers + random sound selection from utils/chime.ts and prune related tests.
  • Remove the Kyleosophy toggle section from the Agent settings behavior page and its Storybook stories.
  • Add planning docs for a future AgentSettingsBehaviorPageView decomposition effort.

Reviewed changes

Copilot reviewed 6 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
site/static/chime_1.mp3 Removes Kyleosophy audio asset.
site/static/chime_2.mp3 Removes Kyleosophy audio asset.
site/static/chime_3.mp3 Removes Kyleosophy audio asset.
site/static/chime_4.mp3 Removes Kyleosophy audio asset.
site/static/chime_5.mp3 Removes Kyleosophy audio asset.
site/static/chime_6.mp3 Removes Kyleosophy audio asset.
site/static/chime_7.mp3 Removes Kyleosophy audio asset.
site/static/chime_8.mp3 Removes Kyleosophy audio asset.
site/src/pages/AgentsPage/utils/chime.ts Reverts chime logic to always play /chime.mp3 and removes Kyleosophy-related exports/state.
site/src/pages/AgentsPage/utils/chime.test.ts Deletes Kyleosophy-related test coverage and imports.
site/src/pages/AgentsPage/AgentSettingsBehaviorPageView.tsx Removes the Kyleosophy settings UI and its associated state/imports.
site/src/pages/AgentsPage/AgentSettingsBehaviorPageView.stories.tsx Removes Kyleosophy-related Storybook stories.
docs/plans/agent-settings-behavior-decomposition.md Adds a plan doc (includes Kyleosophy removal as Phase 0 plus future refactor steps).
docs/plans/agent-settings-behavior-decomposition-research.md Adds research notes supporting the decomposition plan.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/plans/agent-settings-behavior-decomposition.md Outdated
@johnstcn johnstcn changed the base branch from release/2.33.0-rc to release/2.32 April 9, 2026 08:09
@f0ssel f0ssel merged commit 8d4148b into release/2.32 Apr 9, 2026
26 of 28 checks passed
@f0ssel f0ssel deleted the cj/r233/rm-kyleosophy branch April 9, 2026 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants