feat: add per-chat tree-level spend limits#24151
Draft
ibetitsmike wants to merge 5 commits intomainfrom
Draft
Conversation
2f43ec0 to
52de662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional per-chat spend limit that governs the total cost of a
chat tree (root chat plus all subagent descendants). When the cumulative
total_cost_microsacross the tree reaches the limit, further messagesare rejected with a 409 containing
scope: "chat_lifetime".Database: migration 000463 adds nullable
spend_limit_microscolumnwith a
CHECK (> 0)constraint.GetChatTreeSpendTotalsums pricedmessages across the root and all descendants.
Enforcement:
checkChatTreeSpendLimitresolves the root chat,fetches its limit, and compares against tree spend. Runs before the
existing account-period check in
SendMessage,EditMessage, andPromoteQueued. Fails open on lookup errors to avoid blocking usersduring transient DB issues.
API:
CreateChatRequestaccepts optionalspend_limit_micros(validated > 0).
ChatUsageLimitExceededResponsegains ascopefield(
account_periodorchat_lifetime) andresets_atis now optional(nil for lifetime limits).