test(site/src/pages/AgentsPage): add Debug panel Storybook stories#23921
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 846b8bda15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
846b8bd to
ce7722a
Compare
b67aae1 to
2bb04f1
Compare
ce7722a to
a438aad
Compare
2bb04f1 to
9e5bdfd
Compare
9e5bdfd to
cb3da60
Compare
a438aad to
ab825f3
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab825f31bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cb3da60 to
52a4b9d
Compare
ab825f3 to
d8d79ef
Compare
52a4b9d to
6481b60
Compare
d8d79ef to
57dc11a
Compare
6481b60 to
6b4f8e2
Compare
1a7d92e to
0c93cd7
Compare
049b797 to
f7a54c1
Compare
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
Summary
Testing
PR
Screenshot
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Added a dedicated |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6540bd27aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
whoops, seems like the rebase broke some tests here. looking into it |
mafredri
left a comment
There was a problem hiding this comment.
Round 9. Story file unchanged since R5 (approved). All prior findings resolved. 13/13 stories pass.
One new observation from Chopper and Bisky: DebugRunCard has three internal rendering branches after a run is expanded (detail loading, detail error, empty steps) with no story coverage. This is one component layer deeper than the panel-level states covered in R3. The risk is low since these branches use shared primitives (Alert, Spinner, plain text), but the branching logic itself is untested. Posted as a P3 inline.
"A developer who breaks the error alert rendering inside an expanded run card would get no failing test." -- Chopper
🤖 This review was automatically generated with Coder Agents.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merge activity
|
Change-Id: Ie8f0165549c1e0d2e7467a753539d9ef4e296876 Signed-off-by: Thomas Kosiewski <tk@coder.com>
… Disabled story exercising enabled=false path Change-Id: I458599156f70563c97ca963dea634823b4f6b620 Signed-off-by: Thomas Kosiewski <tk@coder.com>
… invalid Settings hint assertion from Disabled story Change-Id: I215699d56b4374c0ad7f5fc190c8024f08a5bba1 Signed-off-by: Thomas Kosiewski <tk@coder.com>
…er DebugRunCard detail branches Add three stories that exercise the detail loading spinner, detail error Alert, and empty-steps fallback rendered by DebugRunCard after a run is expanded. Also realign the ErrorStateWithRedactedHeaders assertion on the rendered error message instead of the non-rendered error code, matching DebugStepCard's getErrorMessage-based output. Change-Id: Id04f57852686688d8a6188f61972df506b409026 Signed-off-by: Thomas Kosiewski <tk@coder.com>

Summary
Add comprehensive Storybook stories covering the Debug panel in various states: loading, empty, single/multiple runs, expanded steps, tool calls, error states, and streaming indicators.
This is PR 9/9 in the chat debug logging stack.
Changes
site/src/pages/AgentsPage/components/RightPanel/DebugPanel/DebugPanel.stories.tsx): Storybook stories withplayfunctions for interaction testing, covering:Stack overview
Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh