Skip to content

ci: don't cancel in-progress linear release runs on main#23766

Merged
ethanndickson merged 1 commit into
mainfrom
linear-sync-t2vc
Mar 30, 2026
Merged

ci: don't cancel in-progress linear release runs on main#23766
ethanndickson merged 1 commit into
mainfrom
linear-sync-t2vc

Conversation

@ethanndickson
Copy link
Copy Markdown
Member

@ethanndickson ethanndickson commented Mar 30, 2026

The Linear Release workflow had cancel-in-progress: true unconditionally, so a new push to main would cancel an already-running sync. This meant successive PR merges would show you a bunch of red Xs on CI, even though nothing was wrong.

image

Other workflows like CI guard against this with cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}.

This PR does the same thing to the linear release workflow. The job will be queued instead.

image

Letting the job finish is not particularly wasteful or anything since the sync takes 30~ seconds in CI time.

@ethanndickson ethanndickson changed the title ci(linear-release): don't cancel in-progress runs on main ci: don't cancel in-progress linear release runs on main Mar 30, 2026
@ethanndickson ethanndickson marked this pull request as ready for review March 30, 2026 07:55
@ethanndickson ethanndickson requested a review from matifali March 30, 2026 08:01
Copy link
Copy Markdown
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ethan :)

Comment thread .github/workflows/linear-release.yaml Outdated
Comment on lines +16 to +17
# Queue rather than cancel so back-to-back pushes to main don't cancel the first sync.
cancel-in-progress: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How Linear Sync works is that it syncs all commits between the last sync and the current commit. So technically it doesn't have to run on each commit to main.

With cancel-in-progress: true, we were saving for some CI minutes.

Another option is to move this to run on schedule, but that has the downside of making Sync stale.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking from me. As the cost is not a big issue here. I wanted to note the point. Thanks

Copy link
Copy Markdown
Member Author

@ethanndickson ethanndickson Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're saving max like 30 seconds of CI by cancelling, so I figured it was fine. We don't have any other jobs that regularly cause red Xs that we don't try and do something about.

@ethanndickson ethanndickson merged commit f2a7fda into main Mar 30, 2026
32 checks passed
@ethanndickson ethanndickson deleted the linear-sync-t2vc branch March 30, 2026 09:46
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants