feat: enable multiple provider configs per provider family by ibetitsmike · Pull Request #23647 · coder/coder

ibetitsmike · 2026-03-26T00:28:25Z

Depends on #24145.

Enable full multi-provider config support: runtime key resolution via provider_config_id binding, frontend UI for managing provider configs, and removal of the single-provider-per-family guard.

Runtime (coderd/x/chatd):

Resolve API keys via provider_config_id binding for bound models
Add EnabledProviderByID() cache method for O(1) provider lookup
Handle fallback when bound provider is disabled (with warning log)
Support user provider keys in key resolution
Deep-clone provider keys to prevent cache mutation

Frontend:

Provider config selection in ModelForm for binding models to specific configs
Updated ProvidersSection for provider config management
Handle env-preset sentinel ID in create/update flows
Updated stories and tests

Backend:

Remove single-provider-per-family uniqueness guard from Part 1
Add GetChatProviderByProvider query for multi-provider lookup

ibetitsmike · 2026-03-26T02:59:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2821e52d1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coder-tasks · 2026-03-26T09:20:21Z

Documentation Check

Updates Needed

docs/ai-coder/agents/models.md — The Add a provider section (step 3–4) describes the old flow: "Click the provider you want to configure." The new UI uses a dropdown button to choose a provider family, then opens a create form. The steps should be updated to match. (frontend changes moved to a separate PR — a3e75e4)

New Documentation Needed

docs/ai-coder/agents/models.md — The concept of multiple provider configurations per family (e.g., two OpenAI endpoints for staging vs. production) is not documented. Should explain:
- That admins can add more than one config for the same provider family (e.g., openai)
- The enabled/disabled toggle per config
- Multiple configs can be enabled simultaneously for the same provider family
- A typical use-case: maintaining separate endpoint configs and toggling which are active
- When a bound provider config is disabled, the model falls back to family defaults (with a warning logged)
docs/ai-coder/agents/models.md — The Add a model step 2 ("Click Add and select the provider for the new model") needs updating. The dropdown now lists per-config options based on the following logic: … (frontend changes moved to a separate PR — a3e75e4)
docs/ai-coder/agents/models.md — Deleting a provider config soft-deletes its bound models. When an admin deletes a provider config, all model configs bound to it are soft-deleted first, then the provider row is hard-deleted. Both behaviors are worth calling out — the soft-delete cascade and the fact that deletion is no longer blocked by active chats.

Automated review via Coder Tasks

ibetitsmike · 2026-03-26T16:35:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb050eff3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-26T17:47:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56ff06c31d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-26T19:12:37Z

Deep Review Summary (10 parallel reviewers)

Reviewers: Test Auditor, Edge Case Analyst, Contract Auditor, Database Reviewer, Go Architect, Frontend Reviewer, Security Reviewer, Product Reviewer, Style Reviewer, Go Modernization

Fixed findings (2)

P2 GetEnabledChatProviderByProvider query was non-deterministic with multiple enabled configs. Added ORDER BY created_at ASC LIMIT 1 for stable selection. (Contract Auditor, Database Reviewer, Go Architect)
Nit Misleading test name Conflict renamed to CreateSecondEnabledConfig. (Test Auditor)

Assessed and accepted (not fixing)

Security P1 (assessed as Obs): API returns disabled configs. This is intentional -- the admin panel needs disabled configs visible with toggle switches. Endpoint is admin-only (policy.ActionUpdate, rbac.ResourceDeploymentConfig).
Go Architect P1 (assessed as P3): No guardrail preventing all configs in a family from being disabled. This is acceptable admin behavior; Stage 2 adds per-model config attachments.
Database P1 (assessed as P3): FK removal creates potential orphan risk. Acceptable tradeoff since provider is no longer unique. Delete handler provides application-layer protection.
Product Obs: Runtime selection behavior undocumented. Stage 2 addresses this with explicit priority ordering.
Nits: Duplicate nilUUID constant, intermediate slice in listChatProviders. Minor, not blocking.

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 002286c0a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T00:11:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ceb2d469e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T00:25:41Z

@codex review

ibetitsmike · 2026-03-27T00:35:59Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77ff9ca671

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T01:03:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77ff9ca671

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T01:21:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b315b993e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T01:37:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75430f30ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-03-27T01:47:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b25f1c2c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-08T19:00:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcbf8bc75d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-08T19:09:58Z

@codex review

mafredri

Round 22 of 4 reviewers (Mafuuu, Hisoka, Chopper, Knov). Wildcard: Knov. Large rebase, no changes to files with open findings.

All 5 findings confirmed by 4/4 reviewers. One new P2: ChatProviderAPIKeysFromDeploymentValues extracts bridge API keys but not their paired base URLs, so custom endpoint deployments (Azure OpenAI, corporate proxy) will silently fail when bridge keys are used for chat.

Severity count: 1x P0 (F50), 4x P2 (F34, F49, F51, F53 new), 1x P3 (F52).

F50 (shouldCleanUnboundModelsAfterProviderDelete test failure) remains a CI blocker. Verified failing again this round.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c50570f3c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mafredri

Round 23 of 4 reviewers (Mafuuu, Hisoka, Knuckle, Razor). Wildcard: Razor.

F50 (P0 test failure), F51 (P2 env-preset visibility), F52 (P3 SQL tautology) all resolved in c50570f. Verified: shouldCleanUnboundModelsAfterProviderDelete test passes, env-preset re-add loop is correct, SQL collapsed with honest comment.

Three P2 findings remain open (F34, F49, F53), confirmed by all 4 reviewers. No new findings posted.

F49 (auto-binding) is now at 8 rounds without response. F53 (bridge keys without base URLs) at 2 rounds.

Severity count: 3x P2.

ibetitsmike · 2026-04-08T20:20:45Z

@codex review

mafredri

Round 24 of 3 reviewers (Mafuuu, Hisoka, Kite). Wildcard: Kite. No code changes since round 23.

All 3 findings confirmed by 3/3 reviewers. No new findings. No author responses.

F49 (auto-binding) at 9 rounds. F53 (bridge keys without base URLs) at 3 rounds. F34 (no non-admin test) at 10+ rounds.

Severity count: 3x P2.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb6fbb33ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-08T20:45:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a6041f4d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibetitsmike · 2026-04-08T21:07:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99f3074124

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

mafredri

Round 25 of 3 reviewers (Mafuuu, Hisoka, Chopper). Wildcard: Chopper.

F53 (bridge keys without base URLs) resolved in eb6fbb3. Base URLs now propagated with test coverage for both populated and empty cases.

Two P2 findings remain open (F34, F49), confirmed by 3/3 reviewers. Both threads were marked Resolved on GitHub without code changes.

No new findings posted. The PR is converging.

Severity count: 2x P2.

mafredri

Round 26 of 3 reviewers (Mafuuu, Hisoka, Meruem). Wildcard: Meruem. No code changes since round 25.

Both findings confirmed by 3/3 reviewers. No new findings. Both threads marked Resolved on GitHub without code changes.

F34 (no non-admin test for listChatModels) at 10+ rounds. F49 (auto-binding) at 10+ rounds.

Severity count: 2x P2.

mafredri

Round 27 of 3 reviewers (Mafuuu, Hisoka, Knov). Wildcard: Knov. No code changes since round 25.

Both findings confirmed by 3/3 reviewers. No new findings posted. Reviewers re-raised previously discussed items (bridge key reversal, mutable var, bound-to-disabled fallback) which were evaluated and closed in earlier rounds.

F34 (no non-admin test) and F49 (auto-binding) both at 10+ rounds. Both threads Resolved on GitHub without code changes.

Severity count: 2x P2.

mafredri

Round 28 of 3 reviewers (Mafuuu, Hisoka, Chopper). Wildcard: Chopper. No code changes since round 25.

Both findings confirmed by 3/3 reviewers. No new findings posted. Reviewers re-raised previously-evaluated items (bridge key reversal, disabled-bound fallback, double user-key query, sentinel pattern, function coverage) which were closed or accepted in prior rounds.

F34 and F49 both at 10+ rounds. Both threads Resolved on GitHub without code changes.

Severity count: 2x P2.

mafredri

Round 29: churn guard verdict is BLOCKED. No reviewers spawned.

F53 (bridge keys without base URLs): resolved in eb6fbb3.

F49 (auto-binding): contested by author. Defense: intentional Stage 1 behavior; migration backfill mirrors it; changing to unbound would alter shipped semantics. Code unchanged. The reviewers will evaluate this defense when the block is lifted.

F34 (no non-admin test for listChatModels): silent. Author deferred in round 9 with "I'll track this as a follow-up" and no ticket was linked. Thread marked Resolved on GitHub without a code change. Non-admin tests were added to TestListChatModelConfigs (a different endpoint), not TestListChatModels. 10+ rounds without resolution.

Further review is blocked until F34 is addressed (test added or ticket linked) or the author responds substantively to the finding.

github-actions bot assigned ibetitsmike Mar 26, 2026

ibetitsmike mentioned this pull request Mar 26, 2026

feat: model-level provider priority lists with runtime fallback #23649

Open

ibetitsmike changed the title ~~feat(chatd): support multiple provider configs per provider family~~ feat: support multiple provider configs per provider family Mar 26, 2026

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

Comment thread coderd/exp_chats.go Outdated

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch from 2821e52 to a475e54 Compare March 26, 2026 09:18

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch from 325a0d8 to eb050ef Compare March 26, 2026 16:35

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch from 5b08692 to 56ff06c Compare March 26, 2026 17:52

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

Comment thread coderd/exp_chats.go Outdated

chatgpt-codex-connector bot reviewed Mar 26, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

Comment thread coderd/exp_chats.go Outdated

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch 2 times, most recently from e44bf71 to ceb2d46 Compare March 27, 2026 00:11

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread coderd/database/migrations/000463_multi_provider_configs.up.sql

Comment thread coderd/exp_chats.go Outdated

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread coderd/database/chatproviders.go

Comment thread site/src/pages/AgentsPage/components/ChatModelAdminPanel/ProviderForm.tsx Outdated

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread coderd/x/chatd/configcache.go Outdated

chatgpt-codex-connector bot reviewed Mar 27, 2026

View reviewed changes

Comment thread site/src/pages/AgentsPage/components/ChatModelAdminPanel/modelProviderOptions.ts Outdated

ibetitsmike requested a review from mafredri April 8, 2026 19:00

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread coderd/exp_chats.go

Comment thread coderd/x/chatd/chatd.go

mafredri reviewed Apr 8, 2026

View reviewed changes

Comment thread coderd/exp_chats.go Outdated

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread coderd/exp_chats.go

Comment thread coderd/x/chatd/chatd.go

ibetitsmike requested a review from mafredri April 8, 2026 19:52

mafredri reviewed Apr 8, 2026

View reviewed changes

ibetitsmike requested a review from mafredri April 8, 2026 20:13

mafredri reviewed Apr 8, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread site/src/pages/AgentsPage/components/ChatModelAdminPanel/ModelForm.tsx Outdated

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread coderd/exp_chats.go

Comment thread site/src/pages/AgentsPage/components/ChatModelAdminPanel/ProviderForm.tsx Outdated

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

Comment thread coderd/exp_chats.go

ibetitsmike requested a review from mafredri April 8, 2026 21:25

mafredri reviewed Apr 8, 2026

View reviewed changes

ibetitsmike requested a review from mafredri April 8, 2026 21:42

mafredri reviewed Apr 8, 2026

View reviewed changes

ibetitsmike requested a review from mafredri April 8, 2026 22:02

mafredri reviewed Apr 8, 2026

View reviewed changes

ibetitsmike requested a review from mafredri April 9, 2026 05:37

mafredri reviewed Apr 9, 2026

View reviewed changes

ibetitsmike added a commit that referenced this pull request Apr 9, 2026

fix: keep PR #23647 backend-only

cc30959

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch from 99f3074 to cc30959 Compare April 9, 2026 10:48

fix: keep PR #23647 backend-only

a3e75e4

ibetitsmike force-pushed the mike/multi-provider-configs-stage1 branch from cc30959 to a3e75e4 Compare April 9, 2026 15:14

ibetitsmike requested a review from mafredri April 10, 2026 10:08

mafredri reviewed Apr 10, 2026

View reviewed changes

Conversation

ibetitsmike commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibetitsmike commented Mar 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

coder-tasks bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation Check

Updates Needed

New Documentation Needed

Uh oh!

ibetitsmike commented Mar 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Mar 26, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 26, 2026

Deep Review Summary (10 parallel reviewers)

Fixed findings (2)

Assessed and accepted (not fixing)

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ibetitsmike commented Mar 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

ibetitsmike commented Mar 26, 2026 •

edited

Loading

coder-tasks bot commented Mar 26, 2026 •

edited

Loading