Skip to content

chore: attempt to nudge agents away from dbauthz.AsSystemRestricted #23326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstcn merged 2 commits into from
Mar 20, 2026
Merged

chore: attempt to nudge agents away from dbauthz.AsSystemRestricted #23326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36427e
chore: attempt to nudge agents away from the horror
johnstcn Mar 19, 2026
9356dd5
Update coderd/database/dbauthz/dbauthz.go
johnstcn Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions coderd/database/dbauthz/dbauthz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,9 @@ func AsSubAgentAPI(ctx context.Context, orgID uuid.UUID, userID uuid.UUID) conte

// AsSystemRestricted returns a context with an actor that has permissions
// required for various system operations (login, logout, metrics cache).
// DO NOT USE THIS UNLESS YOU HAVE ABSOLUTELY NO OTHER CHOICE. Prefer using a
// more specific As* helper above (or adding a new, narrowly-scoped one) so
// that permissions remain limited to the operation you need.
Copy link
Copy Markdown
Member

@mafredri mafredri Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could even flag this // Deprecated:. 😄

Copy link
Copy Markdown
Member Author

@johnstcn johnstcn Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the last-ditch option TBH :D

func AsSystemRestricted(ctx context.Context) context.Context {
return As(ctx, subjectSystemRestricted)
}
Expand Down
Loading