Skip to content

ci: add verbose flag to flux reconcile and increase helmrelease timeout#23240

Merged
dannykopping merged 2 commits into
mainfrom
deploy-workflow-verbosity
Mar 18, 2026
Merged

ci: add verbose flag to flux reconcile and increase helmrelease timeout#23240
dannykopping merged 2 commits into
mainfrom
deploy-workflow-verbosity

Conversation

@dannykopping
Copy link
Copy Markdown
Contributor

@dannykopping dannykopping commented Mar 18, 2026

Disclaimer: implemented by a Coder Agent using Claude Opus 4.6

Ref: https://github.com/coder/coder/actions/runs/23251163568/job/67597250364

The deploy workflow Flux reconciliation step failed with no visibility into what went wrong. Two changes:

  • Add --verbose to every flux reconcile invocation to print generated objects on failure
  • Increase --timeout for the four helmrelease reconciliations from the default 5m to 10m

@github-actions github-actions Bot added the community Pull Requests and issues created by the community. label Mar 18, 2026
…imeouts

Add structured logging to every stage in deploy.yaml:
- UTC timestamps before and after each step
- Explicit timeout-minutes on every step and job
- Summary of all step timeouts printed at the start of the deploy job
- On failure: dump deployment describe, pod status, events, flux status
- Wrap flux reconcile and kubectl rollout in helper functions with
  per-resource error diagnostics
- Add timeout-minutes to should-deploy (5m) and deploy-wsproxies (30m) jobs
- Add set -euxo pipefail and structured output to wsproxy deploys
@dannykopping dannykopping force-pushed the deploy-workflow-verbosity branch 2 times, most recently from c38241b to c4a6f33 Compare March 18, 2026 16:46
@dannykopping dannykopping changed the title ci: increase deploy workflow verbosity with timestamps and explicit timeouts ci: add timestamps and failure diagnostics to Flux reconciliation Mar 18, 2026
@dannykopping dannykopping force-pushed the deploy-workflow-verbosity branch 5 times, most recently from 69d800c to 6099b99 Compare March 18, 2026 16:52
@dannykopping dannykopping changed the title ci: add timestamps and failure diagnostics to Flux reconciliation ci: add verbose flag to flux reconcile and increase helmrelease timeout Mar 18, 2026
@dannykopping dannykopping force-pushed the deploy-workflow-verbosity branch from 6099b99 to 8bee756 Compare March 18, 2026 16:54
@dannykopping dannykopping requested a review from kylecarbs March 18, 2026 16:54
@dannykopping dannykopping marked this pull request as ready for review March 18, 2026 16:54
@dannykopping dannykopping requested review from johnstcn and removed request for jdomeracki-coder March 18, 2026 16:59
Comment thread .github/workflows/deploy.yaml Outdated
Comment on lines +112 to +117
flux --namespace flux-system reconcile --verbose source git flux-system
flux --namespace flux-system reconcile --verbose source git coder-main
flux --namespace flux-system reconcile --verbose kustomization flux-system
flux --namespace flux-system reconcile --verbose kustomization coder
flux --namespace flux-system reconcile --verbose source chart coder-coder
flux --namespace flux-system reconcile --verbose source chart coder-coder-provisioner
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump the recon timeout on the source / ks as well? Do those also default to 5m?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5m by default, yeah
I'll make them explicit

@dannykopping dannykopping force-pushed the deploy-workflow-verbosity branch from 8bee756 to a39a837 Compare March 18, 2026 17:06
Add --verbose to every flux reconcile invocation for better
diagnostics on failure, and increase the timeout for helmrelease
reconciliations from the default 5m to 10m.

Ref: https://github.com/coder/coder/actions/runs/23251163568/job/67597250364
@dannykopping dannykopping force-pushed the deploy-workflow-verbosity branch from a39a837 to 185e396 Compare March 18, 2026 17:07
@dannykopping dannykopping enabled auto-merge (squash) March 18, 2026 17:07
@dannykopping dannykopping merged commit 4b8a5e2 into main Mar 18, 2026
20 checks passed
@dannykopping dannykopping deleted the deploy-workflow-verbosity branch March 18, 2026 17:12
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community Pull Requests and issues created by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants