ci: add lint check to prevent single quotes in bootstrap scripts#22664
Merged
Conversation
Bootstrap scripts under provisionersdk/scripts/ are inlined into
templates via sh -c '${init_script}'. Any single quote character
in these .sh files silently breaks the shell quoting, preventing
agent startup.
Add scripts/check_bootstrap_quotes.sh that rejects single quotes
in bootstrap shell scripts, and wire it into make lint as
lint/bootstrap.
Fixes #22062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Bootstrap scripts under
provisionersdk/scripts/are inlined into templates viash -c '${init_script}'. Any single quote (apostrophe) in these.shfiles silently breaks the shell quoting, causing the agent to never start — with near-invisible error output.Changes
scripts/check_bootstrap_quotes.sh— new lint script that scans all.shfiles underprovisionersdk/scripts/for single quotes and fails with a clear error if any are found. Only checks shell scripts (not.ps1, which legitimately uses single quotes).Makefile— addedlint/bootstraptarget wired into thelintdependency list.Fixes #22062