Repository navigation
Conversation
Switch from Yarn Classic (1.22) to Yarn Berry (3.1.1) in order to speed up install and builds.
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 68.31% 68.44% +0.13%
==========================================
Files 111 111
Lines 6003 6003
Branches 67 67
==========================================
+ Hits 4101 4109 +8
+ Misses 1512 1507 -5
+ Partials 390 387 -3
Continue to review full report at Codecov.
|
|
How much does this improve build times? |
kylecarbs
left a comment
There was a problem hiding this comment.
Seems fine to me, but I'd like @bryphe-coder to take a look!
| /.yarn/* | ||
| !/.yarn/patches | ||
| !/.yarn/plugins | ||
| !/.yarn/releases | ||
| !/.yarn/sdks |
There was a problem hiding this comment.
Will this affect the directories we need to cache in our workflow? ie
coder/.github/workflows/coder.yaml
Line 60 in c44d036
There was a problem hiding this comment.
yea it would. I think it'd be much faster with Plug 'n Play mode, but I couldn't get that working
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "coder-v2", | |||
| "packageManager": "yarn@3.1.1", | |||
There was a problem hiding this comment.
Thanks for investigating this!
|
No-op vs the With yarn 3 + pnp: |
|
Running yarn 3: yarn 1: The fresh-install seems comparable but yarn 3 is still surprisingly a little slower. With PnP enabled + yarn 3: |
|
@jawnsy - do you think the benefits of yarn 3 outweigh the additional time for fresh install / no-op install? I'm more concerned about the no-op install because that will be hit in the development flow. From my testing locally - it seems like yarn 3 is (surprisingly) slower in both those cases 😦 Wondering if we should hold off on this until we can investigate the PnP issue and get the perf benefit? |
There was a problem hiding this comment.
Just curious on your thoughts re: perf @jawnsy - did you see different results when you tested?
|
@bryphe-coder and I are going to check this out on Monday for testing Monday to see if we can get PnP working, otherwise I'll just close this :) |
|
After some investigation, it doesn't seem to be a material performance improvement for us, so it's not worth doing at this time |
Switch from Yarn Classic (1.22) to Yarn Berry (3.1.1) in order
to speed up install and builds.