feat: update build url to @username/workspace/builds/buildnumber#2234
Merged
Conversation
johnstcn
requested changes
Jun 10, 2022
Member
johnstcn
left a comment
There was a problem hiding this comment.
Thanks for the PR! Here's some feedback from the backend perspective:
- We should add some unit tests whenever adding a new API route
- HTTP errors related to client request parameters are generally 4XX.
- Don't forget to handle
sql.ErrNoRows!
Comment on lines
+214
to
+233
| users, err := api.Database.GetUsersByIDs(r.Context(), []uuid.UUID{workspace.OwnerID, workspaceBuild.InitiatorID}) | ||
| if err != nil { | ||
| httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{ | ||
| Message: "Internal error fetching user.", | ||
| Detail: err.Error(), | ||
| }) | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
Remark (non-blocking): If we end up having the concept of "system" or "ghost" users with reserved UUIDs, we'll need to make sure that this findUser function is aware of these.
Contributor
Author
There was a problem hiding this comment.
Do you think it worth making a pass through the repo to find such occurrences and commenting around them for future reference?
Member
There was a problem hiding this comment.
Do you think it worth making a pass through the repo to find such occurrences and commenting around them for future reference?
Not just yet. It's more of something to keep in mind if or when we do have "system" or "ghost" users.
mafredri
reviewed
Jun 10, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
Nice PR with both front- and backend changes! Cian already left a great (backend) review so not much to add.
b2b5fe5 to
e60aa38
Compare
johnstcn
approved these changes
Jun 10, 2022
Member
johnstcn
left a comment
There was a problem hiding this comment.
Looks good to me from the backend perspective!
I'll defer to others on the frontend part.
Kira-Pilot
reviewed
Jun 10, 2022
| export const WorkspaceBuildPage: FC = () => { | ||
| const buildId = useBuildId() | ||
| const [buildState] = useMachine(workspaceBuildMachine, { context: { buildId } }) | ||
| const { username, workspace: workspaceName, buildNumber } = useParams() |
Member
There was a problem hiding this comment.
ya, just like this! and I love that alias 🎈
Member
|
I won't have time to review it today, but the others got it! 🥳🥳🥳 |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* update build url to @username/workspace/builds/buildnumber * update errors thrown from the API * add unit tests for the new API * add t.parallel * get username and workspace name from params
Kira-Pilot
added a commit
that referenced
this pull request
Jun 14, 2022
* feat: update build url to @username/workspace/builds/buildnumber (#2234) * update build url to @username/workspace/builds/buildnumber * update errors thrown from the API * add unit tests for the new API * add t.parallel * get username and workspace name from params * fix: update icon (#2216) * feat: Show template description in `coder template init` (#2238) * fix: workspace schedule time displays (#2249) Summary: Various time displays weren't quite right. Details: - Display date (not just time) of upcoming workspace stop in workspace page - Fix ttlShutdownAt for various cases + tests - manual to non-manual - unchanged/unmodified - isBefore --> isSameOrBefore - use the delta (off by _ error) - pluralize units in dayjs.add * fix: Remove easter egg mentioning competitor (#2250) This is more confusing than helpful! * feat: Warn on coderd startup if access URL is localhost (#2248) * feat: use custom wireguard reverse proxy for dev tunnel (#1975) * fix: use correct link in create from template button (#2253) * feat: store and display template creator (#2228) * design commit * add owner_id to templates table * add owner information in apis and ui * update minWidth for statItem * rename owner to created_by * missing refactor to created_by * handle errors in fetching created_by names * feat: update language on workspace page (#2220) * fix: ensure config dir exists before reading tunnel config (#2259) * fix(devtunnel): close `http.Server` before wireguard interface (#2263) * fix: ensure `agentResource` is non-nil (#2261) * chore: add hero image to OSS docs homepage (#2241) * fix: Do not write 2 errors to api on template fetch error (#2285) * feat: add tooltips to templates page resolves #2242 Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com> Co-authored-by: Joe Previte <jjprevite@gmail.com> Co-authored-by: Mathias Fredriksson <mafredri@gmail.com> Co-authored-by: G r e y <grey@coder.com> Co-authored-by: Kyle Carberry <kyle@coder.com> Co-authored-by: David Wahler <david@coder.com> Co-authored-by: Colin Adler <colin1adler@gmail.com> Co-authored-by: Garrett Delfosse <garrett@coder.com> Co-authored-by: Katie Horne <katie@coder.com> Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the build URL from /builds/<build_id> to /@/<workspace_name>/builds/<build_number>.
Subtasks
Fixes #1906
Screenshot