chore: add compose alternative to develop.sh#22157
Conversation
Documentation CheckUpdates Needed
Automated review via Coder Tasks |
| environment: | ||
| POSTGRES_USER: coder | ||
| POSTGRES_PASSWORD: coder | ||
| POSTGRES_DB: coder |
There was a problem hiding this comment.
Our makefile uses user postgres and db postgres
Lines 1153 to 1155 in ec36617
There was a problem hiding this comment.
What particular Makefile target isn't working for you?
There was a problem hiding this comment.
Makefile is working, just saying you are making the user/pass coder/coder. It's postgres/postgres in our existing develop.sh
There was a problem hiding this comment.
It's
postgres/postgresin our existing develop.sh
I don't see any mention of postgres in develop.sh? coderd does spin up embedded postgres, but that uses coder/${random_password}/coder by default.
| # Add the Docker group so coderd can access the Docker socket. | ||
| # Override DOCKER_GROUP if your host's docker group is not 999. | ||
| group_add: | ||
| - "${DOCKER_GROUP:-999}" |
There was a problem hiding this comment.
This is going to break for everyone 😢
For now just add a comment somewhere to do:
export DOCKER_GROUP=$(getent group docker | cut -d: -f3)
?
Is there a way to make it fail if it's not set?
There was a problem hiding this comment.
We can just wait until we wrap it. So the comment is enough for now probably
Emyrk
left a comment
There was a problem hiding this comment.
When we add the wrapper we can handle running this from different directories too.
Adds a
compose.dev.ymlintended as a pure-Docker alternative todevelop.sh.