Skip to content

feat: Initial workspaces page route + skeleton - #220

Merged
bryphe-coder merged 14 commits into
mainfrom
bryphe/feat/workspaces-page-skeleton
Feb 16, 2022
Merged

bryphe-coder merged 14 commits into
mainfrom
bryphe/feat/workspaces-page-skeleton

Conversation

@bryphe-coder

Copy link
Copy Markdown
Contributor

This implements an initial route for the workspaces page at /workspaces/{user}/{workspace}, and an additional storybook entry:

image

Just the header is rendering right now. Will be adding the additional sections prototyped in #219 in subsequent PRs

Related to #67

@bryphe-coder bryphe-coder self-assigned this Feb 9, 2022
@codecov

codecov Bot commented Feb 9, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #220 (35318a4) into main (6009c90) will decrease coverage by 0.30%.
The diff coverage is 42.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   67.98%   67.67%   -0.31%     
==========================================
  Files         132      135       +3     
  Lines        7099     7149      +50     
  Branches       70       73       +3     
==========================================
+ Hits         4826     4838      +12     
- Misses       1783     1820      +37     
- Partials      490      491       +1     
Flag Coverage Δ
unittest-go-macos-latest 65.96% <ø> (-0.21%) ⬇️
unittest-go-ubuntu-latest 67.09% <ø> (-0.29%) ⬇️
unittest-go-windows-latest 65.98% <ø> (+0.13%) ⬆️
unittest-js 64.61% <42.00%> (-1.62%) ⬇️
Impacted Files Coverage Δ
site/components/Workspace/index.ts 0.00% <0.00%> (ø)
site/pages/workspaces/[user]/[workspace].tsx 0.00% <0.00%> (ø)
site/components/Workspace/Workspace.tsx 100.00% <100.00%> (ø)
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
peer/conn.go 77.17% <0.00%> (-2.06%) ⬇️
coderd/provisionerdaemons.go 57.84% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6009c90...35318a4. Read the comment docs.

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread site/pages/workspaces/[user]/[workspace].tsx
@bryphe-coder

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing @kylecarbs 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants