fix(coderd): disallow POSTing a workspace build on a deleted workspace#20584
Merged
Conversation
DanielleMaywood
approved these changes
Oct 30, 2025
Member
|
I think allowing extra
There are no other ways for a workspace to become Obviously, if someone uploaded a custom state on their build the story is a bit different, which is why I think it's fine to leave it in the API. But I don't think anyone will ever need to do it so I don't think we should add it to the CLI/UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It looks like, for a good long while, we have allows POSTing a workspace build on a deleted workspace. As far as I can tell, this goes way back (to at least 2.21, but maybe earlier).
Credit to @DanielleMaywood
Impact
Proposed Solution
This PR adds a check on
/api/v2/workspacebuildsto disallow creating a START or STOP build if the workspace is deleted. I elected to allow a DELETE build however.Remediation
I haven't added any automatic remediation, but below is a (Claude-coded) SQL query that should show affected workspaces and associated resources: