Skip to content

feat: add prebuilds reconciliation duration metric#20535

Merged
ssncferreira merged 4 commits into
mainfrom
ssncferreira/feat-prebuilds-reconciliation-duration-metric
Oct 29, 2025
Merged

feat: add prebuilds reconciliation duration metric#20535
ssncferreira merged 4 commits into
mainfrom
ssncferreira/feat-prebuilds-reconciliation-duration-metric

Conversation

@ssncferreira
Copy link
Copy Markdown
Contributor

@ssncferreira ssncferreira commented Oct 29, 2025

Description

Adds coderd_prebuilds_reconciliation_duration_seconds histogram metric to track the duration of each prebuilds reconciliation cycle.

This metric helps operators monitor reconciliation performance and identify potential bottlenecks.

Changes

  • Added ReconcileStats struct to capture reconciliation cycle statistics
  • Updated ReconcileAll() to return stats including elapsed time
  • Added histogram metric coderd_prebuilds_reconciliation_duration_seconds

@ssncferreira ssncferreira force-pushed the ssncferreira/feat-prebuilds-reconciliation-duration-metric branch from f0b3617 to 19fa823 Compare October 29, 2025 10:31
@ssncferreira ssncferreira marked this pull request as ready for review October 29, 2025 10:31
Copy link
Copy Markdown
Contributor

@SasSwart SasSwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One nonblocking question.

Comment thread enterprise/coderd/prebuilds/reconcile_test.go
@ssncferreira ssncferreira merged commit aad1b40 into main Oct 29, 2025
25 checks passed
@ssncferreira ssncferreira deleted the ssncferreira/feat-prebuilds-reconciliation-duration-metric branch October 29, 2025 12:52
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2025
@ssncferreira ssncferreira added the cherry-pick/v2.28 Needs to be cherry-picked to the 2.28 release branch label Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-pick/v2.28 Needs to be cherry-picked to the 2.28 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants