chore: refactor license validation#20411
Merged
Merged
Conversation
johnstcn
reviewed
Oct 22, 2025
| } | ||
| if claims.LicenseExpires == nil { | ||
|
|
||
| yearsHardLimit := time.Now().Add(5 /* years */ * 365 * 24 * time.Hour) |
Member
There was a problem hiding this comment.
Can you add some context on this hard limit?
Comment on lines
+709
to
+714
| if claims.AccountType == "" { | ||
| return nil, ErrMissingAccountType | ||
| } | ||
| if claims.AccountID == "" { | ||
| return nil, ErrMissingAccountID | ||
| } |
Member
There was a problem hiding this comment.
Is there any risk of breaking existing licenses?
Member
Author
There was a problem hiding this comment.
There shouldn't be. Coder-issued licenses have these fields populated:
"license_expires": 1223242222,
"account_type": "trial", // or something else
"account_id": "user@domain.tld", // or something special
DanielleMaywood
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the logic used to validate license claims.