fix(coderd/provisionerdserver): pipe through task id and prompt#20408
Merged
Conversation
b56410a to
d1fba16
Compare
0e77536 to
39eca6a
Compare
d1fba16 to
2f8619d
Compare
39eca6a to
316b12b
Compare
9299e77 to
625db35
Compare
5fc4328 to
ef433cc
Compare
625db35 to
5c5117f
Compare
8fd3604 to
6cc3b03
Compare
5c5117f to
a4df0c8
Compare
9220413 to
e605686
Compare
Base automatically changed from
mafredri/refactor-coderd-use-tasks-data-model-in-list
to
main
October 23, 2025 17:22
a4df0c8 to
9638ae7
Compare
johnstcn
approved these changes
Oct 24, 2025
mafredri
reviewed
Oct 24, 2025
| var taskID string | ||
| task, err := s.Database.GetTaskByWorkspaceID(ctx, workspaceBuild.WorkspaceID) | ||
| if err != nil && !errors.Is(err, sql.ErrNoRows) { | ||
| return nil, xerrors.Errorf("failed to get task by workspace id: %w", err) |
Member
There was a problem hiding this comment.
Suggested change
| return nil, xerrors.Errorf("failed to get task by workspace id: %w", err) | |
| return nil, xerrors.Errorf("get task by workspace id: %w", err) |
mafredri
approved these changes
Oct 24, 2025
Member
mafredri
left a comment
There was a problem hiding this comment.
LGTM, but this change makes me think we should move prompt to the task_workspace_apps table (and maybe that's a bad name for it) 😅
This would essentially always feed the same prompt into the task, right?
Contributor
Author
Yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipes through the Task's ID and prompt into the provisioner. This is required to support the new
coder_ai_task.promptfield and modifiedcoder_ai_task.idfield.