chore(coderd): introduce TaskAppID and deprecate AITaskSidebarAppID#20336
Merged
DanielleMaywood merged 2 commits intoOct 24, 2025
Merged
Conversation
37589a9 to
0b96862
Compare
As we're moving away from the SidebarAppID nomenclature, this PR introduces a new `TaskAppID` field to `codersdk.WorkspaceBuild` and deprecates the `AITaskSidebarAppID` field. They both contain the same value.
0b96862 to
b62e70b
Compare
Member
|
Can this wait until @mafredri 's stack goes in? |
Contributor
Author
|
@johnstcn Yep |
aslilac
reviewed
Oct 21, 2025
Member
aslilac
left a comment
There was a problem hiding this comment.
frontend changes are all small and obvious enough :)
johnstcn
approved these changes
Oct 24, 2025
mafredri
approved these changes
Oct 24, 2025
| if appURL == "" { | ||
| return httperror.NewResponseError(http.StatusInternalServerError, codersdk.Response{ | ||
| Message: "Task sidebar app URL is not configured.", | ||
| Message: "Task app URL is not configured.", |
Member
There was a problem hiding this comment.
Could this be enforced provider-side? 🤔 It's unfortunate to let it be a runtime error that basically turns the task defunct 😅.
Member
There was a problem hiding this comment.
I'm not sure if you can do cross-resource validation in Terraform, and you define the url in the workspace_app resource :(
Member
There was a problem hiding this comment.
Then validation on provisioner side would perhaps be an option.
Contributor
Author
There was a problem hiding this comment.
That makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're moving away from the SidebarAppID nomenclature, this PR introduces a new
TaskAppIDfield tocodersdk.WorkspaceBuildand deprecates theAITaskSidebarAppIDfield. They both contain the same value.