Skip to content

feat(scaletest): extend notifications runner with smtp support#20222

Merged
kacpersaw merged 1 commit into
mainfrom
kacpersaw/scaletest-notifications-smtp
Oct 22, 2025
Merged

feat(scaletest): extend notifications runner with smtp support#20222
kacpersaw merged 1 commit into
mainfrom
kacpersaw/scaletest-notifications-smtp

Conversation

@kacpersaw
Copy link
Copy Markdown

@kacpersaw kacpersaw commented Oct 8, 2025 •
edited
Loading

This PR extends the scaletest notification runner with SMTP support.

If the --smtp-api-url flag is provided, the runner will also watch for SMTP notifications using the specified URL.

Changes

  • Added a new watcher to retrieve emails sent to the runner user
  • Tracked WebSocket and SMTP latencies separately
  • Updated metrics to include notification_id and notification_type labels

CLI Flags

  • --smtp-api-url: Address of the SMTP mock HTTP API used to retrieve email notifications

Metrics

  • notification_delivery_latency_seconds now includes:
    • notification_id
    • notification_type (websocket or smtp)

@kacpersaw Graphite App
Copy link
Copy Markdown
Author

kacpersaw commented Oct 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kacpersaw kacpersaw mentioned this pull request Oct 8, 2025
Merged
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch from d943527 to 9411ea4 Compare October 8, 2025 15:14
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-smtp-mock-server branch from 5830a76 to 20790fc Compare October 8, 2025 16:02
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch 3 times, most recently from 7c9356f to df56754 Compare October 8, 2025 16:43
@kacpersaw kacpersaw requested a review from spikecurtis October 8, 2025 16:57
@kacpersaw kacpersaw marked this pull request as ready for review October 8, 2025 16:57
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch 2 times, most recently from 9bf2971 to b32040f Compare October 14, 2025 10:38
spikecurtis
spikecurtis reviewed Oct 14, 2025
View reviewed changes
Comment thread cli/exp_scaletest.go Outdated
Comment thread cli/exp_scaletest.go Outdated
Comment thread scaletest/notifications/run_test.go
Comment thread scaletest/notifications/run.go Outdated
Comment thread scaletest/notifications/run.go Outdated
Comment thread scaletest/notifications/run.go Outdated
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch from c47fb2a to a1ad593 Compare October 14, 2025 16:09
@kacpersaw
Copy link
Copy Markdown
Author

kacpersaw commented Oct 15, 2025

@spikecurtis also, I extracted the notifications CLI command into a separate file because it was getting too long

@kacpersaw kacpersaw requested a review from spikecurtis October 21, 2025 06:58
spikecurtis
spikecurtis reviewed Oct 21, 2025
View reviewed changes
Comment thread cli/exp_scaletest_notifications.go Outdated
Comment thread scaletest/notifications/run.go Outdated
Comment thread scaletest/notifications/run_test.go Outdated
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch from 19a48ec to dc86db2 Compare October 21, 2025 13:50
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-smtp-mock-server branch from dc3c69d to adc1c9f Compare October 21, 2025 13:50
@kacpersaw kacpersaw requested a review from spikecurtis October 21, 2025 14:36
@kacpersaw Graphite App
Copy link
Copy Markdown
Author

kacpersaw commented Oct 22, 2025 •
edited
Loading

Merge activity

  • Oct 22, 9:14 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 22, 9:16 AM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 22, 9:33 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'required', 'test-go-pg (windows-2022)').

@kacpersaw kacpersaw changed the base branch from kacpersaw/scaletest-smtp-mock-server to graphite-base/20222 October 22, 2025 09:14
@kacpersaw kacpersaw changed the base branch from graphite-base/20222 to main October 22, 2025 09:14
@kacpersaw kacpersaw force-pushed the kacpersaw/scaletest-notifications-smtp branch from dc86db2 to ec1deda Compare October 22, 2025 09:15
@kacpersaw kacpersaw merged commit 1230cac into main Oct 22, 2025
45 of 47 checks passed
@kacpersaw kacpersaw deleted the kacpersaw/scaletest-notifications-smtp branch October 22, 2025 10:09
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@kacpersaw kacpersaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kacpersaw @spikecurtis