chore: bring back x-auth-checks with a length limit#19928
Merged
Conversation
ThomasK33
approved these changes
Sep 24, 2025
Comment on lines
+36
to
+37
| checks = checks[:maxHeaderLength] | ||
| checks += "<truncated>" |
Member
There was a problem hiding this comment.
Nit: Won't this result in a header that is 2011 bytes long, since maxHeaderLength + len("<truncated>")
Suggested change
| checks = checks[:maxHeaderLength] | |
| checks += "<truncated>" | |
| truncationMarker = "<truncated>" | |
| checks = checks[:(maxHeaderLength - len(truncationMarker))] | |
| checks += truncationMarker |
Member
Author
There was a problem hiding this comment.
I thought about that, but figured it wouldn't hurt to let it be a tiny bit longer 😄
Emyrk
reviewed
Sep 24, 2025
|
|
||
| // This is defined separately in slim builds to avoid importing the rbac | ||
| // package, which is a large dependency. | ||
| func SetAuthzCheckRecorderHeader(ctx context.Context, rw http.ResponseWriter) { |
Member
There was a problem hiding this comment.
We could technically find the size of the other headers to, and check how large they are. Then make sure they never exceed 4kb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We disabled it before because the header could get too long and cause problems. I've re-enabled it with a maximum length and a comment describing why the length matters. Any results that are truncated will be marked as such. It's not a perfect solution, but this is a useful debugging tool that I want to bring back.