feat: add tooltip field to workspace app that renders as markdown#19651
Merged
Conversation
added 6 commits
August 29, 2025 22:13
aslilac
reviewed
Sep 2, 2025
Contributor
buenos-nachos
left a comment
There was a problem hiding this comment.
Things look pretty good to me on the frontend side
spikecurtis
requested changes
Sep 3, 2025
added 5 commits
September 3, 2025 10:41
spikecurtis
approved these changes
Sep 4, 2025
Contributor
spikecurtis
left a comment
There was a problem hiding this comment.
lgtm from the standpoint of the proto. Deferring to other reviewers for the wholistic view.
aslilac
approved these changes
Sep 4, 2025
buenos-nachos
approved these changes
Sep 5, 2025
Contributor
buenos-nachos
left a comment
There was a problem hiding this comment.
Everything looks good on my end!
| {primaryTooltip ? ( | ||
| primaryTooltip | ||
| ) : app.tooltip ? ( | ||
| <Markdown className="text-content-secondary prose-sm font-medium wrap-anywhere"> |
Contributor
There was a problem hiding this comment.
Oh, neat. Didn't realize that we had Tailwind's typography plugin installed. Being able to use prose classes should help a lot for markdown concerns
johnstcn
approved these changes
Sep 8, 2025
Member
|
@rafrdz, as a follow-up, please update the dogfood/coder template so we can start dogfooding. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request we're adding an optional
tooltipfield. Thetooltipfield is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.Tooltip screenshot
Tooltip video
tooltip-link.mov
Issue: #18431
Related provider PR: coder/terraform-provider-coder#435
Changes
tooltipcolumn toworkspace_appstabletooltipcolumnTesting
Applinkmarkdown rendering