feat: Improve empty states for workspaces and templates#1950
Merged
Conversation
added 7 commits
May 31, 2022 17:26
Kira-Pilot
reviewed
Jun 1, 2022
AbhineetJain
reviewed
Jun 1, 2022
Kira-Pilot
reviewed
Jun 1, 2022
greyscaled
reviewed
Jun 1, 2022
Comment on lines
+9
to
+10
| className?: string | ||
| buttonClassName?: string |
Contributor
There was a problem hiding this comment.
Thought: One thing to consider here is mimicking MUIs API.
These use a classes object, so it would look like this:
<CodeExample classes={{ root: ..., button: ..., }} />
I'm adding this as a thought because it's not required to do anything now, just wanted to pose the question.
Might make sense as a FE V topic.
Contributor
Author
There was a problem hiding this comment.
I agree with you, but I see some components are already using the pattern elementClassName so I just keep it for consistency but IMO, we should try to use the classes prop to keep parity with MUIs API.
Co-authored-by: G r e y <grey@coder.com>
Kira-Pilot
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo:
https://user-images.githubusercontent.com/3165839/171438664-c599a10a-3261-4d9d-8042-5bec6c1281c6.mov
Closes #1926