Skip to content

feat: add OAuth2 client credentials grant type and user ownership#18841

Closed
ThomasK33 wants to merge 1 commit into
thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokensfrom
thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership
Closed

feat: add OAuth2 client credentials grant type and user ownership#18841
ThomasK33 wants to merge 1 commit into
thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokensfrom
thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership

Conversation

@ThomasK33
Copy link
Copy Markdown
Member

@ThomasK33 ThomasK33 commented Jul 12, 2025

  • Add client_credentials to OAuth2ProviderGrantType enum
  • Add user_id column to oauth2_provider_apps for ownership tracking
  • Make refresh_hash nullable for client credentials tokens per RFC 6749
  • Update API schemas to use proper OAuth2 enums for grant/response types
  • Add grant_types field to OAuth2 app create/update requests
  • Support user-scoped client credentials apps vs system-scoped auth flows
  • Update database queries and models for new fields

Change-Id: I11901919656c86c51e7c808324e2df5205eda002
Signed-off-by: Thomas Kosiewski tk@coder.com

@ThomasK33 ThomasK33 mentioned this pull request Jul 12, 2025
Closed
@ThomasK33 ThomasK33 self-assigned this Jul 12, 2025
This was referenced Jul 12, 2025
Closed
Closed
@ThomasK33 Graphite App
Copy link
Copy Markdown
Member Author

ThomasK33 commented Jul 12, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 changed the title feat(oauth2): add client credentials grant type and user ownership feat: add OAuth2 client credentials grant type and user ownership Jul 12, 2025
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch 3 times, most recently from bd2e4f2 to f44982c Compare July 12, 2025 14:41
@ThomasK33 ThomasK33 marked this pull request as ready for review July 13, 2025 10:36
@ThomasK33 ThomasK33 requested review from Emyrk and johnstcn July 13, 2025 10:36
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 50a22db to 93a1a1d Compare July 14, 2025 12:43
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from f44982c to c654948 Compare July 14, 2025 12:43
This was referenced Jul 14, 2025
Closed
Closed
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from c654948 to eac2681 Compare July 14, 2025 16:22
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 93a1a1d to 5c7f06a Compare July 14, 2025 16:22
@ThomasK33 ThomasK33 changed the base branch from thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens to graphite-base/18841 July 14, 2025 17:10
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from eac2681 to ac0d1f6 Compare July 14, 2025 17:18
@ThomasK33 ThomasK33 force-pushed the graphite-base/18841 branch from 5c7f06a to 0393465 Compare July 14, 2025 17:18
@ThomasK33 ThomasK33 changed the base branch from graphite-base/18841 to thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens July 14, 2025 17:19
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from ac0d1f6 to ef3c66e Compare July 15, 2025 17:27
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 0393465 to 643824a Compare July 15, 2025 17:27
@ThomasK33 ThomasK33 mentioned this pull request Jul 15, 2025
Closed
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 643824a to f2c16b5 Compare July 17, 2025 14:38
@ThomasK33 ThomasK33 requested a review from aslilac as a code owner July 17, 2025 14:38
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from ef3c66e to 3f1495c Compare July 17, 2025 14:38
@aslilac aslilac removed their request for review July 23, 2025 16:35
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from 3f1495c to 2fc275d Compare July 23, 2025 16:53
@ThomasK33 ThomasK33 mentioned this pull request Jul 23, 2025
Closed
@github-actions github-actions Bot added the stale This issue is like stale bread. label Jul 31, 2025
@github-actions github-actions Bot closed this Aug 3, 2025
@ThomasK33 ThomasK33 removed the stale This issue is like stale bread. label Aug 12, 2025
@ThomasK33 ThomasK33 assigned Emyrk and unassigned ThomasK33 Aug 12, 2025
@ThomasK33 ThomasK33 reopened this Aug 12, 2025
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from 2fc275d to 59463e3 Compare August 12, 2025 16:32
@github-actions github-actions Bot added the stale This issue is like stale bread. label Aug 20, 2025
@github-actions github-actions Bot closed this Aug 24, 2025
@Emyrk Emyrk reopened this Aug 24, 2025
@github-actions github-actions Bot removed the stale This issue is like stale bread. label Aug 25, 2025
@github-actions github-actions Bot added the stale This issue is like stale bread. label Sep 1, 2025
@github-actions github-actions Bot closed this Sep 5, 2025
@ThomasK33 ThomasK33 deleted the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch September 15, 2025 07:52
@ThomasK33 ThomasK33 restored the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch September 15, 2025 07:53
@Emyrk Emyrk reopened this Oct 6, 2025
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 4a7aa03 to 0c3e711 Compare October 10, 2025 14:42
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch 2 times, most recently from 487fa65 to c5bbc6e Compare October 10, 2025 14:53
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 0c3e711 to 67b504e Compare October 10, 2025 14:53
@ThomasK33
feat(oauth2): add client credentials grant type and user ownership
c659bbc 
- Add client_credentials to OAuth2ProviderGrantType enum
- Add user_id column to oauth2_provider_apps for ownership tracking
- Make refresh_hash nullable for client credentials tokens per RFC 6749
- Update API schemas to use proper OAuth2 enums for grant/response types
- Add grant_types field to OAuth2 app create/update requests
- Support user-scoped client credentials apps vs system-scoped auth flows
- Update database queries and models for new fields

Change-Id: I11901919656c86c51e7c808324e2df5205eda002
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 67b504e to fa6dc8d Compare October 10, 2025 14:57
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from c5bbc6e to c659bbc Compare October 10, 2025 14:57
@johnstcn johnstcn removed their request for review January 26, 2026 09:22
@github-actions github-actions Bot removed the stale This issue is like stale bread. label Apr 9, 2026
@github-actions github-actions Bot added the stale This issue is like stale bread. label Apr 30, 2026
@Emyrk Emyrk closed this May 1, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
@github-actions github-actions Bot deleted the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch May 2, 2026 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@Emyrk Emyrk

Labels

stale This issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomasK33 @Emyrk