Skip to content

chore: remove dbmem - #18803

Merged
hugodutka merged 2 commits into
mainfrom
hugodutka/remove-dbmem
Jul 9, 2025
Merged

chore: remove dbmem#18803
hugodutka merged 2 commits into
mainfrom
hugodutka/remove-dbmem

Conversation

@hugodutka

@hugodutka hugodutka commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

Remove the in-memory database. Addresses #15109.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ../admin/infrastructure/validated-architectures/index.md#general-concepts Status: 404 Cannot find: ../admin/infrastructure/validated-architectures/index.md#general-concepts

* [General Concepts](../admin/infrastructure/validated-architectures/index.md#general-concepts): Essential concepts and language used to describe how Coder is structured and operated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ../admin/infrastructure/architecture.md Status: 404 Cannot find: ../admin/infrastructure/architecture.md

* [Architecture](../admin/infrastructure/architecture.md): A high-level overview of the infrastructure layout, key services, and how components interact.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui Status: 404

* [cli](https://github.com/coder/coder/tree/main/cli): CLI interface for `coder` command built on [coder/serpent](https://github.com/coder/serpent). Input controls are defined in [cliui](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui), and [testdata](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata) contains golden files for common CLI calls

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata Status: 404

* [cli](https://github.com/coder/coder/tree/main/cli): CLI interface for `coder` command built on [coder/serpent](https://github.com/coder/serpent). Input controls are defined in [cliui](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/cliui), and [testdata](https://github.com/coder/coder/tree/docs-backend-contrib-guide/cli/testdata) contains golden files for common CLI calls

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/coder/coder/blob/docs-backend-contrib-guide/coderd/database/queries.sql.go Status: 404

* [queries](https://github.com/coder/coder/tree/main/coderd/database/queries): contains SQL files with queries, `sqlc` compiles them to [Go functions](https://github.com/coder/coder/blob/docs-backend-contrib-guide/coderd/database/queries.sql.go)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/fixtures Status: 404 Cannot find: ../../coderd/database/migrations/testdata/fixtures

[`migrations/testdata/fixtures`](../../coderd/database/migrations/testdata/fixtures)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/full_dumps Status: 404 Cannot find: ../../coderd/database/migrations/testdata/full_dumps

[`migrations/testdata/full_dumps`](../../coderd/database/migrations/testdata/full_dumps)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql Status: 404 Cannot find: ../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql

[`000024_example.up.sql`](../../coderd/database/migrations/testdata/fixtures/000024_example.up.sql)

@hugodutka
hugodutka force-pushed the hugodutka/remove-dbmem branch from c78f161 to 1699c6d Compare July 8, 2025 16:38
@hugodutka

hugodutka commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

As far as I can tell, neither the changes in UI tests nor the linkspector errors are related to this PR. UI changes stem from some storybook views containing random strings that may change between CI runs, and the links are broken on main.

@hugodutka
hugodutka marked this pull request as ready for review July 8, 2025 16:52
@hugodutka
hugodutka requested a review from deansheather July 8, 2025 16:52

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

It appears remaining tests depending on having dbmem have been addressed in #18797

I don't see any issues here, but deferring to Dean for approval.

@hugodutka

Copy link
Copy Markdown
Contributor Author

@johnstcn there were more PRs actually: #15109 (comment)

@deansheather deansheather left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫰

@hugodutka
hugodutka force-pushed the hugodutka/remove-dbmem branch from 1699c6d to b14e99c Compare July 9, 2025 07:32
@hugodutka
hugodutka merged commit 3c2f3d6 into main Jul 9, 2025
27 of 30 checks passed
@hugodutka
hugodutka deleted the hugodutka/remove-dbmem branch July 9, 2025 07:46
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants