feat: add search to parameter dropdowns#18729
Merged
Merged
Conversation
buenos-nachos
approved these changes
Jul 14, 2025
buenos-nachos
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall! Just had a few suggestions
| import { cn } from "utils/cn"; | ||
|
|
||
| interface ComboboxProps { | ||
| value: string; |
Contributor
There was a problem hiding this comment.
I know this was here originally, but I can't help but feel like selectedValue would be more clear, especially to avoid ambiguity with inputValue
Member
Author
There was a problem hiding this comment.
I think value is well enough established as "the current value of the input". what I would really like to change is inputValue -> searchValue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coder/preview#81