Skip to content

fix: remove unique constraint on OAuth2 provider app names#18669

Merged
ThomasK33 merged 1 commit into
mainfrom
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance
Jul 3, 2025
Merged

fix: remove unique constraint on OAuth2 provider app names#18669
ThomasK33 merged 1 commit into
mainfrom
thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance

Conversation

@ThomasK33
Copy link
Copy Markdown
Member

@ThomasK33 ThomasK33 commented Jun 30, 2025 •
edited
Loading

Remove unique constraint on OAuth2 provider app names

This PR removes the unique constraint on the name field in the oauth2_provider_apps table to comply with RFC 7591, which only requires unique client IDs, not unique client names.

Changes include:

  • Removing the unique constraint from the database schema
  • Adding migration files for both up and down migrations
  • Removing the name uniqueness check in the in-memory database implementation
  • Updating the unique constraint constants

Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8a
Signed-off-by: Thomas Kosiewski tk@coder.com

This was referenced Jun 30, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ThomasK33 Graphite App
Copy link
Copy Markdown
Member Author

ThomasK33 commented Jun 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 30, 2025
Merged
Merged
@ThomasK33 ThomasK33 changed the title feat(oauth2): remove unique constraint on app names for RFC 7591 compliance fix: remove unique constraint on OAuth2 provider app names Jun 30, 2025
@ThomasK33 ThomasK33 marked this pull request as ready for review June 30, 2025 16:43
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 4efb07a to 8a3f7a9 Compare June 30, 2025 16:45
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 58b076d to 88f01e4 Compare June 30, 2025 16:45
@ThomasK33 ThomasK33 requested review from johnstcn and mafredri June 30, 2025 16:52
@mafredri
Copy link
Copy Markdown
Member

mafredri commented Jun 30, 2025

@ThomasK33 tests seem unhappy 😔

@ThomasK33 Graphite App
Copy link
Copy Markdown
Member Author

ThomasK33 commented Jun 30, 2025

@ThomasK33 tests seem unhappy 😔

Yeah, I forgot to update them. On it.

@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 8a3f7a9 to e7d56c2 Compare June 30, 2025 17:08
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 88f01e4 to 0d042a4 Compare June 30, 2025 17:56
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from e7d56c2 to 10701da Compare June 30, 2025 17:56
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 0d042a4 to f4614fd Compare July 1, 2025 09:15
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch 2 times, most recently from a2607a8 to 990f706 Compare July 1, 2025 09:27
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from f4614fd to 5943be1 Compare July 1, 2025 09:27
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 990f706 to 95c0496 Compare July 1, 2025 13:23
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 5943be1 to 2e85437 Compare July 1, 2025 13:23
@ThomasK33 ThomasK33 mentioned this pull request Jul 1, 2025
Merged
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 2e85437 to aa379a5 Compare July 1, 2025 13:42
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from f8aa2de to 9851f81 Compare July 2, 2025 13:58
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from b7601e7 to ce40271 Compare July 2, 2025 14:06
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 9851f81 to 43ac8a0 Compare July 2, 2025 14:06
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from ce40271 to 4095815 Compare July 2, 2025 15:51
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 43ac8a0 to 57a9498 Compare July 2, 2025 15:52
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 4095815 to df954c4 Compare July 2, 2025 16:35
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 57a9498 to 398ecea Compare July 2, 2025 16:35
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from df954c4 to 2168bf9 Compare July 2, 2025 16:45
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 398ecea to 65635f0 Compare July 2, 2025 16:46
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 2168bf9 to 9d2fe4d Compare July 2, 2025 17:00
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 65635f0 to 27135bd Compare July 2, 2025 17:00
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 9d2fe4d to 95ea96c Compare July 2, 2025 17:15
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 27135bd to f4cdc20 Compare July 2, 2025 17:16
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch from 95ea96c to c667cbf Compare July 3, 2025 15:00
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from f4cdc20 to 0ca3722 Compare July 3, 2025 15:00
This was referenced Jul 3, 2025
Merged
Merged
@ThomasK33 ThomasK33 force-pushed the thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows branch 2 times, most recently from dca4260 to 3813249 Compare July 3, 2025 16:34
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 0ca3722 to 838d1de Compare July 3, 2025 16:34
@ThomasK33 ThomasK33 changed the base branch from thomask33/06-27-docs_refactor_claude.md_to_use_import_system_and_comprehensive_workflows to graphite-base/18669 July 3, 2025 16:51
@ThomasK33 ThomasK33 force-pushed the graphite-base/18669 branch from 3813249 to 4dcf0c3 Compare July 3, 2025 16:51
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 838d1de to 32959fe Compare July 3, 2025 16:51
@graphite-app graphite-app Bot changed the base branch from graphite-base/18669 to main July 3, 2025 16:52
@ThomasK33
feat(oauth2): remove unique constraint on app names for RFC 7591 comp…
6634f47 
…liance

Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8a
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch from 32959fe to 6634f47 Compare July 3, 2025 16:52
@ThomasK33 ThomasK33 merged commit 60b08f0 into main Jul 3, 2025
30 checks passed
@ThomasK33 Graphite App
Copy link
Copy Markdown
Member Author

ThomasK33 commented Jul 3, 2025

Merge activity

@ThomasK33 ThomasK33 deleted the thomask33/06-30-feat_oauth2_remove_unique_constraint_on_app_names_for_rfc_7591_compliance branch July 3, 2025 17:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@ThomasK33 ThomasK33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasK33 @mafredri @johnstcn