Skip to content

test: ignore context.Canceled in acquireWithCancel#17448

Merged
spikecurtis merged 1 commit into
mainfrom
spike/internal-584
Apr 17, 2025
Merged

test: ignore context.Canceled in acquireWithCancel#17448
spikecurtis merged 1 commit into
mainfrom
spike/internal-584

Conversation

@spikecurtis

@spikecurtis spikecurtis commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

fixes coder/internal#584

Ignore canceled error when sending an acquired job, since dRPC is racy and will sometimes return this error even after successfully sending the job, if the test is quickly finished.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested a review from johnstcn April 17, 2025 10:54
@spikecurtis spikecurtis marked this pull request as ready for review April 17, 2025 10:54
@spikecurtis spikecurtis merged commit b3aba6d into main Apr 17, 2025
@spikecurtis spikecurtis deleted the spike/internal-584 branch April 17, 2025 12:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: TestProvisionerd/MaliciousTar

2 participants