feat(agent): implement recreate for devcontainers#17308
Merged
Conversation
91dfec3 to
0098663
Compare
0098663 to
6d18522
Compare
DanielleMaywood
approved these changes
Apr 10, 2025
Contributor
DanielleMaywood
left a comment
There was a problem hiding this comment.
looks good to me 👍
johnstcn
approved these changes
Apr 10, 2025
Member
johnstcn
left a comment
There was a problem hiding this comment.
Nice work! I especially like the test helper thing you added 👍
| return | ||
| } | ||
|
|
||
| containers, err := ch.cl.List(ctx) |
Member
There was a problem hiding this comment.
Potential follow-up (non-blocking): I wonder if we should also add an Inspect() method to the Lister; listing the entire containers endpoint is probably wasteful.
e2d5de8 to
f5e2328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements an interface for running
@devcontainers/cli upand an API endpoint on the agent for triggering recreate for a running devcontainer.A couple of limitations:
Both 1 and 2 will be improved in future refactors.
Fixes coder/internal#481
Fixes coder/internal#482