Skip to content

feat: extend request logs with auth & DB info#17304

Merged
ibetitsmike merged 13 commits into
mainfrom
mike/16903-extend-request-logs
Apr 15, 2025
Merged

feat: extend request logs with auth & DB info#17304
ibetitsmike merged 13 commits into
mainfrom
mike/16903-extend-request-logs

Conversation

@ibetitsmike
Copy link
Copy Markdown
Collaborator

@ibetitsmike ibetitsmike commented Apr 9, 2025 •
edited
Loading

Closes #16903

@ibetitsmike ibetitsmike changed the title expanded user query with email on authorization and extracted actor i… feat: request logs are extended with user details Apr 9, 2025
@ibetitsmike ibetitsmike force-pushed the mike/16903-extend-request-logs branch from 1263c3c to 9bbef21 Compare April 10, 2025 06:08
@ibetitsmike ibetitsmike changed the title feat: request logs are extended with user details feat: request logs are extended with authentication info Apr 10, 2025
@ibetitsmike ibetitsmike changed the title feat: request logs are extended with authentication info feat: request logs are extended with auth & DB info Apr 10, 2025
deansheather
deansheather reviewed Apr 10, 2025
View reviewed changes
Comment thread Makefile Outdated
Comment thread coderd/database/dbauthz/dbauthz.go Outdated
Comment thread coderd/database/queries.sql.go Outdated
Comment thread coderd/database/queries/users.sql Outdated
Comment thread coderd/rbac/astvalue.go Outdated
@ibetitsmike ibetitsmike force-pushed the mike/16903-extend-request-logs branch 2 times, most recently from e42dc76 to 942437f Compare April 10, 2025 14:30
@ibetitsmike ibetitsmike marked this pull request as ready for review April 11, 2025 10:47
@ibetitsmike ibetitsmike changed the title feat: request logs are extended with auth & DB info feat: extend request logs with auth & DB info Apr 11, 2025
@ibetitsmike ibetitsmike force-pushed the mike/16903-extend-request-logs branch from 4390c4d to 8ef5646 Compare April 14, 2025 10:31
deansheather
deansheather approved these changes Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread coderd/httpmw/loggermw/logger.go Outdated
Comment thread coderd/httpmw/loggermw/logger.go Outdated
@deansheather deansheather requested a review from Emyrk April 15, 2025 01:57
deansheather
deansheather approved these changes Apr 15, 2025
View reviewed changes
Comment thread coderd/httpmw/loggermw/logger.go Outdated
Comment thread coderd/httpmw/loggermw/logger.go Outdated
Comment thread coderd/rbac/authz.go Outdated
@ibetitsmike ibetitsmike merged commit 06d3915 into main Apr 15, 2025
@ibetitsmike ibetitsmike deleted the mike/16903-extend-request-logs branch April 15, 2025 11:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@ibetitsmike
Copy link
Copy Markdown
Collaborator Author

ibetitsmike commented Apr 16, 2025

/cherry-pick release/2.19

@ibetitsmike
Copy link
Copy Markdown
Collaborator Author

ibetitsmike commented Apr 22, 2025

/cherry-pick release/2.21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deansheather deansheather deansheather approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk Emyrk is a code owner

Assignees

@ibetitsmike ibetitsmike

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request logs should contain some resolved information about DB objects

2 participants

@ibetitsmike @deansheather