Skip to content

chore(cli): increase healthcheck timeout in TestSupportbundle#17291

Merged
johnstcn merged 5 commits into
mainfrom
cj/flake/cli/support/NoAgent
Apr 9, 2025
Merged

chore(cli): increase healthcheck timeout in TestSupportbundle#17291
johnstcn merged 5 commits into
mainfrom
cj/flake/cli/support/NoAgent

Conversation

@johnstcn

@johnstcn johnstcn commented Apr 8, 2025

Copy link
Copy Markdown
Member

Fixes coder/internal#272

  • Increases healthcheck timeout in tests. This seems to be the most usual cause of test failures.
  • Adds a non-nilness check before caching a healthcheck report.
  • Modifies the HTTP response code to 503 (was 404) when no healthcheck report is available. 503 seems to be a better indicator of the server state in this case, whereas 404 could be misinterpreted as a typo in the healthcheck URL.

@johnstcn johnstcn self-assigned this Apr 8, 2025
@johnstcn johnstcn changed the title chore(cli): TestSupportbundle: fix test flakes chore(cli): increase healthcheck timeout in TestSupportbundle Apr 8, 2025
Comment thread cli/support_test.go Outdated
@johnstcn johnstcn merged commit a8fbe71 into main Apr 9, 2025
@johnstcn johnstcn deleted the cj/flake/cli/support/NoAgent branch April 9, 2025 08:21
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: TestSupportBundle (multiple variants): health report should not be empty

2 participants