Skip to content

feat: log long-lived connections acceptance#17219

Merged
ibetitsmike merged 40 commits into
mainfrom
mike/16904-request-logging-on-long-lived-connection-opening
Apr 8, 2025
Merged

feat: log long-lived connections acceptance#17219
ibetitsmike merged 40 commits into
mainfrom
mike/16904-request-logging-on-long-lived-connection-opening

Conversation

@ibetitsmike

Copy link
Copy Markdown
Collaborator

Closes #16904

@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/httpmw/logger.go Outdated

@deansheather deansheather left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/inboxnotifications.go Outdated
Comment thread coderd/httpmw/logger.go
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Apr 3, 2025
@ibetitsmike ibetitsmike changed the title Adding logging of opened websocket connections feat: added logging of long lived connections when accepted by the server Apr 3, 2025
@ibetitsmike ibetitsmike marked this pull request as ready for review April 3, 2025 11:46
@ibetitsmike ibetitsmike changed the title feat: added logging of long lived connections when accepted by the server feat: log long-lived connections acceptance Apr 3, 2025
Comment thread coderd/inboxnotifications.go Outdated
Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/httpmw/logger_internal_test.go
Comment thread coderd/httpmw/logger_internal_test.go Outdated
@ibetitsmike ibetitsmike force-pushed the mike/16904-request-logging-on-long-lived-connection-opening branch from 3a16aad to 817b733 Compare April 6, 2025 23:08
Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/httpmw/logger.go Outdated
Comment thread coderd/httpmw/logger.go
Comment thread coderd/httpmw/logger_internal_test.go Outdated
Comment thread coderd/httpmw/logger_internal_test.go Outdated
Comment thread coderd/httpmw/logger_internal_test.go Outdated
Comment thread coderd/httpmw/mocks/mock_request_logger.go
@ibetitsmike ibetitsmike force-pushed the mike/16904-request-logging-on-long-lived-connection-opening branch from 7bb4450 to 09e46d0 Compare April 7, 2025 09:45
Comment thread coderd/httpmw/logger_internal_test.go Outdated
Comment thread coderd/httpmw/logger_internal_test.go Outdated
@ibetitsmike ibetitsmike enabled auto-merge (squash) April 8, 2025 08:05
@ibetitsmike ibetitsmike merged commit ce22de8 into main Apr 8, 2025
@ibetitsmike ibetitsmike deleted the mike/16904-request-logging-on-long-lived-connection-opening branch April 8, 2025 08:30
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2025
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

/cherry-pick release/2.19

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

/cherry-pick release/2.20

@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

/cherry-pick release/2.21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long-lived requests (websockets, SSE) should log request as soon as they start to block

2 participants