fix: rewrite login type migrations#16978
Merged
Merged
Conversation
dannykopping
approved these changes
Mar 18, 2025
dannykopping
left a comment
Contributor
There was a problem hiding this comment.
Thanks for sorting this out 👍
| -- The original disregarded the warning in create_migration.sh. | ||
| -- As a result, it was not possible to insert a user with the "none" login type | ||
| -- in a migration. | ||
| -- The new implementation makes the same changes as the original, but |
Contributor
There was a problem hiding this comment.
Nit: this comment should rather just going into the PR description, and the original argument should be copied over as well. Linking to a GH commit might not always work, or be difficult to find once the comment is resolved.
Contributor
Author
There was a problem hiding this comment.
I'm going to keep a trimmed version of the comment in the migration if its all the same, but I will update the PR description with some more detail.
Contributor
There was a problem hiding this comment.
Sounds good; for consistency should it not go in both files then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to add system users, we discovered an issue in two migrations that added values to the login_type enum.
After some consideration, we decided to retroactively correct them.