chore: add "user_configs" db table#16564
Merged
Merged
Conversation
Member
Author
|
pls don't close my pr github |
6f61953 to
0590d77
Compare
johnstcn
reviewed
Feb 28, 2025
johnstcn
approved these changes
Mar 5, 2025
johnstcn
reviewed
Mar 5, 2025
Member
|
Since we're no longer sending the |
Member
|
@ethanndickson would it suffice to re-add the field in the /api/v2/users response but mark it as deprecated? EDIT: this was already done as part of this PR, the only other change was adding |
Member
|
I think the change is fine honestly, but if it's breaking our own Coder integration (desktop), it's possible it could break someone else's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
"user_configs"tableMoves the data from the
"users"."theme_preference"column to this new table as a bit of a proof of conceptThe idea is that this table will enable future feature development to have a nice spot to put user specific settings, like storing the state of dismissed notification banners, or other UI personalizations that we may add in the future. It could even be used to remember values from partial form completions, or all manner of other things, (and in a place where they can later be invalidated by the backend, rather than put in
localStorage)