chore(coderd): remove the window option in open_in#16104
Conversation
|
Relates to coder/terraform-provider-coder#297 |
johnstcn
left a comment
There was a problem hiding this comment.
We will still have the database enum type 'window'::workspace_app_open_in hanging around; I think we should drop this also.
| WINDOW = 0; | ||
| SLIM_WINDOW = 1; | ||
| TAB = 2; | ||
| SLIM_WINDOW = 0; |
There was a problem hiding this comment.
Let's keep the WINDOW member but mark it as deprecated.
As discussed, there's no way to remove an enum entry in Postgres so it's probably fine to just leave it lying around instead of the nonsense involved to get it removed properly.
|
@dannykopping @johnstcn as per the comments and discussions we had, I :
|
johnstcn
left a comment
There was a problem hiding this comment.
LGTM
I was going to suggest updating the description of the enum 'window'::workspace_app_open_in to mark it as deprecated, but it's not possible at the schema level as far as I can tell.
|
@defelmnq have we also removed the related changes from https://github.com/coder/terraform-provider-coder? |
Not yet, I merge this one as soon as possible to unblock bruno - but will have to create also one indeed on the tf-provider-coder 👍 |
As we worked on adding a
open_inparameter for workspace_apps - we initially created three options :After further investigation,
windowshould not be used and has to be removed.ℹ️ I decided to remove the option instead of deprecating it as we've not created any release nor documented the feature. Can be discussed.