chore(coderd): extract fileszip to its own package for reuse#15229
Merged
Conversation
johnstcn
commented
Oct 25, 2024
Comment on lines
+22
to
+28
| func TestTarFileBytes() []byte { | ||
| return append([]byte{}, testTarFileBytes...) | ||
| } | ||
|
|
||
| func TestZipFileBytes() []byte { | ||
| return append([]byte{}, testZipFileBytes...) | ||
| } |
Member
Author
There was a problem hiding this comment.
review: returning a clone of the byte to avoid accidental mutation in tests
johnstcn
commented
Oct 25, 2024
Comment on lines
+16
to
+20
| //go:embed testdata/test.tar | ||
| var testTarFileBytes []byte | ||
|
|
||
| //go:embed testdata/test.zip | ||
| var testZipFileBytes []byte |
Member
Author
There was a problem hiding this comment.
review: I chose to go:embed these so that we don't end up with silly path errors.
mafredri
approved these changes
Oct 25, 2024
Member
mafredri
left a comment
There was a problem hiding this comment.
Minor nits but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15087
As part of sniffing the workspace tags from an uploaded file, we need to be able to handle both zip and tar files. Extracting the functions in the
fileszippackage will be helpful here.