Skip to content

fix: show audit logs for forgot password flow#15181

Merged
DanielleMaywood merged 7 commits into
mainfrom
dm-forgot-password-audit-logs
Oct 22, 2024
Merged

fix: show audit logs for forgot password flow#15181
DanielleMaywood merged 7 commits into
mainfrom
dm-forgot-password-audit-logs

Conversation

@DanielleMaywood
Copy link
Copy Markdown
Contributor

@DanielleMaywood DanielleMaywood commented Oct 22, 2024

Fixes #15150

Audit logs for requesting a password reset, and a user updating their password, now show up in the audit log.

Screenshot 2024-10-22 at 12 48 27

@DanielleMaywood DanielleMaywood marked this pull request as ready for review October 22, 2024 11:11
Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The only potential quibble I have is the naming -- perhaps "password reset requested" would be more clear?

Comment thread codersdk/audit.go Outdated
Copy link
Copy Markdown
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@DanielleMaywood DanielleMaywood merged commit 5076161 into main Oct 22, 2024
Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DanielleMaywood DanielleMaywood deleted the dm-forgot-password-audit-logs branch October 22, 2024 12:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coderd/audit: ensure audit logs created for user password reset requests

3 participants