Thanks for your contribution! From my perspective, the trial information should always come directly from user input. I don't feel comfortable with allowing trials to be specified directly via CLI environment variables, although I admit there's very little stopping an enterprising user from feeding information in via expect or similar.

@johnstcn should we remove first-user-trial as well from CLI env variables ? because if its true then other variables would also be required, or else we should make those optional

@johnstcn should we remove first-user-trial as well from CLI env variables ? because if its true then other variables would also be required, or else we should make those optional

Let's leave that as-is.

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

@johnstcn should we remove first-user-trial as well from CLI env variables ? because if its true then other variables would also be required, or else we should make those optional

Let's leave that as-is.

@johnstcn
I've addressed the comments and I have checked through the codebase, the only issue I see is that of the use of --first-user-trial here, since the value is set this will prompt to enter the trial details causing the workflow to fail, one option is to set it as --first-user-trial=false, would that be ok?

@joobisb yes set that as false.

@joobisb yes set that as false.

i've updated the PR

Can you rebase on main?

One thing I've noticed is that in develop.sh we set --first-user-trial=true. This breaks the develop.sh workflow slightly as we then prompt for trial info. How about we instead just set --first-user-trial=false? In a separate PR we can modify the develop.sh script to upload a development license from a well-known location.

sure, I thought since it's used in the dev environment, we can always enter values into the prompt. But you are right, to make it more seamless I think we could set it to false.

One thing I've noticed is that in develop.sh we set --first-user-trial=true. This breaks the develop.sh workflow slightly as we then prompt for trial info. How about we instead just set --first-user-trial=false? In a separate PR we can modify the develop.sh script to upload a development license from a well-known location.

sure, I thought since it's used in the dev environment, we can always enter values into the prompt. But you are right, to make it more seamless I think we could set it to false.

updated the PR

@matifali @johnstcn can we merge this ?

@matifali it looks like the e2e-premium tests are failing.
@joobisb Can you try rebasing your PR on latest main?

@matifali it looks like the e2e-premium tests are failing. @joobisb Can you try rebasing your PR on latest main?

@johnstcn done

@matifali can we merge this ?

@sreya, we are blocked here as the secret is unavailable for forks. This is a required test so can not merge without it being passed.