feat(helm): add setting to disable service account creation#14817
Merged
Conversation
Add a setting to disable service account creation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Sep 26, 2024
kylecarbs
reviewed
Sep 27, 2024
Changed to disableCreate
Changed to disableCreate
ericpaulsen
approved these changes
Oct 23, 2024
Member
|
@ericpaulsen Let's make sure there's a corresponding test case for the Helm chart! |
Collaborator
|
Doesn't this change our default behavior? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a setting to disable service account creation