feat: add 'display_name' column to 'workspace_agent_scripts'#14747
Merged
Conversation
dannykopping
approved these changes
Sep 20, 2024
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
LGTM
Would you mind adding some more detail to the description about where this value comes from, and how it will be used?
Contributor
Author
Done! Let me know if you want more detail. |
Contributor
|
Perfect, thanks 👍 |
Contributor
|
@DanielleMaywood should we wait for the other PR to be merged first? |
Contributor
Author
|
I think this PR should go first as this is to pull out the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
display_namecolumn toworkspace_agent_scriptstable.display_nameis sourced fromcoder_scriptresource in the coder terraform provider. It will be used in the UI when we display script timings.Work on #14713 requires
display_nameto be present in the database.