feat: add templates delete command - #1443
Merged
Merged
Conversation
coadler
force-pushed
the
colin/template-delete
branch
from
May 13, 2022 21:54
a1551dc to
f872b51
Compare
Member
|
This is what I like to see Mr. Adler! |
kylecarbs
approved these changes
May 13, 2022
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| var ( | ||
| ctx = cmd.Context() | ||
| templateNames = []string{} |
Member
There was a problem hiding this comment.
This can only be a max of 1 right? I don't believe this needs to be an array!
Contributor
Author
There was a problem hiding this comment.
I forgot to remove the max 1 limit! I think it's nicer if we take in more than one since it plays nicer with xargs.
ammario
requested changes
May 13, 2022
ammario
requested changes
May 13, 2022
This comment was marked as spam.
This comment was marked as spam.
ammario
approved these changes
May 13, 2022
| func templateDelete() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "delete [name...]", | ||
| Short: "Delete templates.", |
Member
There was a problem hiding this comment.
I'm not sure this is a sentence
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1204